Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Mentions): Incorrect line-height from .input() style #17347

Merged
merged 1 commit into from Jun 28, 2019

Conversation

Projects
None yet
2 participants
@dengfuping
Copy link
Member

commented Jun 28, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

👻 What's the background?

  • issue:
    image

image

💡 Solution

📝 Changelog

Language Changelog
🇺🇸 English 🐞Fix incorrect line-height for Mentions.
🇨🇳 Chinese 🐞 修复 Mentions 组件的行高不正确的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label Jun 28, 2019

@netlify

This comment has been minimized.

Copy link

commented Jun 28, 2019

Deploy preview for ant-design processing.

Building with commit 9c9365c

https://app.netlify.com/sites/ant-design/deploys/5d157cf051e5570007bbbd6a

@@ -11,6 +11,7 @@
position: relative;
display: inline-block;
height: auto;
line-height: unset;

This comment has been minimized.

Copy link
@afc163

afc163 Jun 28, 2019

Member

introduced by #17100

@afc163 afc163 merged commit 92f18f3 into master Jun 28, 2019

22 of 26 checks passed

ci/circleci: test_lib_15 CircleCI is running your tests
Details
Header rules - ant-design No header rules processed
Details
LGTM analysis: JavaScript No code changes detected
Details
Pages changed - ant-design 216 new files uploaded
Details
DEP All dependencies are resolved
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No prior size to compare - 852.9 KB
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Jun 28, 2019

@delete-merged-branch delete-merged-branch bot deleted the fix-mentions-height branch Jun 28, 2019

@codecov

This comment has been minimized.

Copy link

commented Jun 28, 2019

Codecov Report

Merging #17347 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17347      +/-   ##
==========================================
- Coverage      96%   95.95%   -0.05%     
==========================================
  Files         263      263              
  Lines        7351     7351              
  Branches     2053     2015      -38     
==========================================
- Hits         7057     7054       -3     
- Misses        292      295       +3     
  Partials        2        2
Impacted Files Coverage Δ
components/_util/wave.tsx 85.84% <0%> (-2.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c391515...9c9365c. Read the comment docs.

@afc163 afc163 referenced this pull request Jun 29, 2019

Closed

add 3.20.0 changelog #17362

5 of 14 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.