Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Mentions): Incorrect line-height from .input() style #17347

Merged
merged 1 commit into from Jun 28, 2019

Conversation

dengfuping
Copy link
Contributor

@dengfuping dengfuping commented Jun 28, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

👻 What's the background?

  • issue:
    image

image

💡 Solution

📝 Changelog

Language Changelog
🇺🇸 English 🐞Fix incorrect line-height for Mentions.
🇨🇳 Chinese 🐞 修复 Mentions 组件的行高不正确的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Jun 28, 2019

Deploy preview for ant-design processing.

Building with commit 9c9365c

https://app.netlify.com/sites/ant-design/deploys/5d157cf051e5570007bbbd6a

@@ -11,6 +11,7 @@
position: relative;
display: inline-block;
height: auto;
line-height: unset;
Copy link
Member

@afc163 afc163 Jun 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

introduced by #17100

@afc163 afc163 merged commit 92f18f3 into master Jun 28, 2019
25 of 26 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix-mentions-height branch Jun 28, 2019
@codecov
Copy link

codecov bot commented Jun 28, 2019

Codecov Report

Merging #17347 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17347      +/-   ##
==========================================
- Coverage      96%   95.95%   -0.05%     
==========================================
  Files         263      263              
  Lines        7351     7351              
  Branches     2053     2015      -38     
==========================================
- Hits         7057     7054       -3     
- Misses        292      295       +3     
  Partials        2        2
Impacted Files Coverage Δ
components/_util/wave.tsx 85.84% <0%> (-2.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c391515...9c9365c. Read the comment docs.

@afc163 afc163 mentioned this pull request Jun 29, 2019
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants