Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: small table header background #17351

Merged
merged 1 commit into from Jun 28, 2019

Conversation

Projects
None yet
1 participant
@afc163
Copy link
Member

commented Jun 28, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

👻 What's the background?

ref #14539

it should be white in our design spec

image

to

image

📝 Changelog

Language Changelog
🇺🇸 English Fixed small Table header background to white according to design spec.
🇨🇳 Chinese 按照设计规范修复小号 Table 的背景色。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label Jun 28, 2019

@buildsize

This comment has been minimized.

Copy link

commented Jun 28, 2019

File name Previous Size New Size Change
package-lock.json 852.9 KB 856.84 KB 3.94 KB (0%)
@netlify

This comment has been minimized.

Copy link

commented Jun 28, 2019

Deploy preview for ant-design processing.

Building with commit 10a3a7f

https://app.netlify.com/sites/ant-design/deploys/5d15a804f6d3f10007cc170c

@afc163 afc163 force-pushed the fix-small-table-header-background branch from 65df78f to 38e19c7 Jun 28, 2019

🐛 Fix small table header background
revert #14539

it should be white in our design spec

@afc163 afc163 force-pushed the fix-small-table-header-background branch from 38e19c7 to 10a3a7f Jun 28, 2019

@afc163 afc163 merged commit 2e5096d into master Jun 28, 2019

4 of 8 checks passed

License Compliance FOSSA is analyzing this commit
Details
ant-design.ant-design in progress
Details
ci/circleci: setup CircleCI is running your tests
Details
LGTM analysis: JavaScript No code changes detected
Details
DEP All dependencies are resolved
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Jun 28, 2019

@delete-merged-branch delete-merged-branch bot deleted the fix-small-table-header-background branch Jun 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.