Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix classname is undefined #17389

Merged
merged 5 commits into from Jul 2, 2019

Conversation

Projects
None yet
3 participants
@chenshuai2144
Copy link
Contributor

commented Jul 1, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

👻 What's the background?

在 className 不传的情况下 会造成 class 中出现 undefined 字符串

💡 Solution

📝 Changelog

Language Changelog
🇺🇸 English Fix the problem that the className is empty and the class name is wrong.
🇨🇳 Chinese 修复 className 为空造成类名错误的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label Jul 1, 2019

@netlify

This comment has been minimized.

Copy link

commented Jul 1, 2019

Deploy preview for ant-design processing.

Building with commit 2c4976b

https://app.netlify.com/sites/ant-design/deploys/5d1af823e67b97000892487b

@codecov

This comment has been minimized.

Copy link

commented Jul 1, 2019

Codecov Report

Merging #17389 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17389      +/-   ##
==========================================
- Coverage   96.03%   95.99%   -0.04%     
==========================================
  Files         267      267              
  Lines        7414     7415       +1     
  Branches     2067     2027      -40     
==========================================
- Hits         7120     7118       -2     
- Misses        292      295       +3     
  Partials        2        2
Impacted Files Coverage Δ
components/result/index.tsx 100% <100%> (ø) ⬆️
components/_util/wave.tsx 85.84% <0%> (-2.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d87bff6...2c4976b. Read the comment docs.

@chenshuai2144

This comment has been minimized.

Copy link
Contributor Author

commented Jul 1, 2019

@afc163 @zombieJ result 是不是不需要背景颜色,我用的时候都需要人肉删除一下背景颜色。有点累人

@zombieJ

This comment has been minimized.

Copy link
Member

commented Jul 1, 2019

@afc163 @zombieJ result 是不是不需要背景颜色,我用的时候都需要人肉删除一下背景颜色。有点累人

去掉吧,背景色应该跟着容器走

@afc163

This comment has been minimized.

Copy link
Member

commented Jul 1, 2019

是应该删,但是你用的时候为啥没背景?

pro 里应该改成有白色背景的。

@chenshuai2144 chenshuai2144 referenced this pull request Jul 2, 2019

Closed

fix result global Icon color #17404

5 of 14 tasks complete
@chenshuai2144

This comment has been minimized.

Copy link
Contributor Author

commented Jul 2, 2019

404 这些的都是没有背景的
不然和项目不搭配了

@chenshuai2144 chenshuai2144 changed the title fix classname is undefined fix: fix classname is undefined Jul 2, 2019

@afc163

This comment has been minimized.

Copy link
Member

commented Jul 2, 2019

404 这些的都是没有背景的

加上,老版本的设计不能这样套到新组件上。这个组件要带白色背景,改成和结果页一致就行。

@zombieJ

zombieJ approved these changes Jul 2, 2019

@chenshuai2144 chenshuai2144 merged commit f096b89 into master Jul 2, 2019

26 of 29 checks passed

License Compliance FOSSA is analyzing this commit
Details
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 219 new files uploaded
Details
DEP All dependencies are resolved
LGTM analysis: JavaScript No new or fixed alerts
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No significant change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 96.03%)
Details
codecov/project Absolute coverage decreased by -0.03% but relative coverage increased by +3.96% compared to d87bff6
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No new issues
Details

@pr-triage pr-triage bot added PR: merged and removed PR: reviewed-approved labels Jul 2, 2019

@chenshuai2144 chenshuai2144 deleted the fix-className-undefined branch Jul 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.