Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm drawer config consumer props #17390

Merged
merged 2 commits into from Jul 4, 2019

Conversation

Projects
None yet
3 participants
@jljsj33
Copy link
Member

commented Jul 1, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

馃挕 Solution

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English
馃嚚馃嚦 Chinese 鍒犻櫎 drawer props 閲岀殑 ConfigConsumerProps锛fix #17387

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label Jul 1, 2019

@jljsj33 jljsj33 requested a review from afc163 Jul 1, 2019

@netlify

This comment has been minimized.

Copy link

commented Jul 1, 2019

Deploy preview for ant-design ready!

Built with commit c020797

https://deploy-preview-17390--ant-design.netlify.com

getPrefixCls,
renderEmpty,
csp,
autoInsertSpaceInButton,

This comment has been minimized.

Copy link
@afc163

afc163 Jul 1, 2019

Member

杩欐牱浠ュ悗 ConfigProvider 鍔犱笢瑗胯繕浼氬嚭鐜帮紝@zombieJ 鐪嬬湅鏈夋病鏈夋洿濂界殑鍔炴硶銆

This comment has been minimized.

Copy link
@zombieJ

zombieJ Jul 1, 2019

Member

鎴戜竴鑸敤鍒颁粈涔堝姞浠涔堬紝rest 浼氭湁鐐瑰鈥︹

This comment has been minimized.

Copy link
@afc163

afc163 Jul 1, 2019

Member

杩欐牱浠ュ悗鍔犱釜灞炴э紝鍙堜細鏈変竴鍫嗘姤閿欍

This comment has been minimized.

Copy link
@zombieJ

zombieJ Jul 1, 2019

Member

鍙互鎶戒竴涓簱澶勭悊 dom attr锛屼紶閫掔粰 dom 鍓 omit 鎺変笉鐢ㄧ殑銆

This comment has been minimized.

Copy link
@afc163

afc163 Jul 1, 2019

Member

鑳藉惁 withConfigConsumer 鍔犱釜鍙傛暟锛屽0鏄庣粍浠剁敤鍒扮殑 props锛岃繖鏍峰悗缁 ConfigProvider 鍔犲睘鎬т笉浼氬奖鍝嶅埌宸叉湁缁勪欢銆

This comment has been minimized.

Copy link
@zombieJ

zombieJ Jul 2, 2019

Member

绫讳技浜 originProps 杩欑鍚楋紵

@zombieJ

This comment has been minimized.

Copy link
Member

commented Jul 2, 2019

CI 鎸備簡

@jljsj33

This comment has been minimized.

Copy link
Member Author

commented Jul 3, 2019

杩 CI 鏄姤鐨勫摢闂ㄥ瓙閿欏晩锛燂紵锛

@zombieJ

This comment has been minimized.

Copy link
Member

commented Jul 3, 2019

鍦 style/index.tsx 閲屽姞涓涓細

// deps-lint-skip: empty

ConfigProvider + renderEmpty 鍛戒腑浜 empty 鐨 rule锛屼互涓虹敤鍒颁簡 Empty 缁勪欢鈥︹

@codecov

This comment has been minimized.

Copy link

commented Jul 3, 2019

Codecov Report

Merging #17390 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17390   +/-   ##
=======================================
  Coverage   96.03%   96.03%           
=======================================
  Files         267      267           
  Lines        7414     7414           
  Branches     2067     2065    -2     
=======================================
  Hits         7120     7120           
  Misses        292      292           
  Partials        2        2
Impacted Files Coverage 螖
components/drawer/index.tsx 98.71% <酶> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update d87bff6...c020797. Read the comment docs.

@lengthmin lengthmin referenced this pull request Jul 4, 2019

Closed

鏇存柊鍒3.20.0鍚庯紝Drawer 鎶藉眽鎶ラ敊 #17387

0 of 1 task complete

@zombieJ zombieJ merged commit a129846 into master Jul 4, 2019

25 of 29 checks passed

License Compliance Analysis done, scanning for issues...
Details
Semantic Pull Request add a semantic commit or PR title
Details
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 217 new files uploaded
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No significant change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing d87bff6...c020797
Details
codecov/project 96.03% remains the same compared to d87bff6
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (ant-design) Test PR is disabled for this project
security/snyk - package.json (paranoidjk) No new issues
Details

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Jul 4, 2019

@delete-merged-branch delete-merged-branch bot deleted the drawer-props branch Jul 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.