Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm drawer config consumer props #17390

Merged
merged 2 commits into from Jul 4, 2019
Merged

rm drawer config consumer props #17390

merged 2 commits into from Jul 4, 2019

Conversation

jljsj33
Copy link
Member

@jljsj33 jljsj33 commented Jul 1, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

馃挕 Solution

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English
馃嚚馃嚦 Chinese 鍒犻櫎 drawer props 閲岀殑 ConfigConsumerProps锛fix #17387

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@jljsj33 jljsj33 requested a review from afc163 Jul 1, 2019
@netlify
Copy link

@netlify netlify bot commented Jul 1, 2019

Deploy preview for ant-design ready!

Built with commit c020797

https://deploy-preview-17390--ant-design.netlify.com

getPrefixCls,
renderEmpty,
csp,
autoInsertSpaceInButton,
Copy link
Member

@afc163 afc163 Jul 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

杩欐牱浠ュ悗 ConfigProvider 鍔犱笢瑗胯繕浼氬嚭鐜帮紝@zombieJ 鐪嬬湅鏈夋病鏈夋洿濂界殑鍔炴硶銆

Copy link
Member

@zombieJ zombieJ Jul 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

鎴戜竴鑸敤鍒颁粈涔堝姞浠涔堬紝rest 浼氭湁鐐瑰鈥︹

Copy link
Member

@afc163 afc163 Jul 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

杩欐牱浠ュ悗鍔犱釜灞炴э紝鍙堜細鏈変竴鍫嗘姤閿欍

Copy link
Member

@zombieJ zombieJ Jul 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

鍙互鎶戒竴涓簱澶勭悊 dom attr锛屼紶閫掔粰 dom 鍓 omit 鎺変笉鐢ㄧ殑銆

Copy link
Member

@afc163 afc163 Jul 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

鑳藉惁 withConfigConsumer 鍔犱釜鍙傛暟锛屽0鏄庣粍浠剁敤鍒扮殑 props锛岃繖鏍峰悗缁 ConfigProvider 鍔犲睘鎬т笉浼氬奖鍝嶅埌宸叉湁缁勪欢銆

Copy link
Member

@zombieJ zombieJ Jul 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

绫讳技浜 originProps 杩欑鍚楋紵

@zombieJ
Copy link
Member

@zombieJ zombieJ commented Jul 2, 2019

CI 鎸備簡

@jljsj33
Copy link
Member Author

@jljsj33 jljsj33 commented Jul 3, 2019

杩 CI 鏄姤鐨勫摢闂ㄥ瓙閿欏晩锛燂紵锛

@zombieJ
Copy link
Member

@zombieJ zombieJ commented Jul 3, 2019

鍦 style/index.tsx 閲屽姞涓涓細

// deps-lint-skip: empty

ConfigProvider + renderEmpty 鍛戒腑浜 empty 鐨 rule锛屼互涓虹敤鍒颁簡 Empty 缁勪欢鈥︹

@codecov
Copy link

@codecov codecov bot commented Jul 3, 2019

Codecov Report

Merging #17390 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17390   +/-   ##
=======================================
  Coverage   96.03%   96.03%           
=======================================
  Files         267      267           
  Lines        7414     7414           
  Branches     2067     2065    -2     
=======================================
  Hits         7120     7120           
  Misses        292      292           
  Partials        2        2
Impacted Files Coverage 螖
components/drawer/index.tsx 98.71% <酶> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update d87bff6...c020797. Read the comment docs.

@zombieJ zombieJ merged commit a129846 into master Jul 4, 2019
27 of 29 checks passed
@delete-merged-branch delete-merged-branch bot deleted the drawer-props branch Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants