Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Form onSubmit type #17412

Merged
merged 1 commit into from Jul 2, 2019

Conversation

Projects
None yet
1 participant
@afc163
Copy link
Member

commented Jul 2, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

👻 What's the background?

close #17400

💡 Solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Form onSubmit type.
🇨🇳 Chinese 修复 Form onSubmit TypeScript 定义。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label Jul 2, 2019

@netlify

This comment has been minimized.

Copy link

commented Jul 2, 2019

Deploy preview for ant-design processing.

Building with commit 32132c5

https://app.netlify.com/sites/ant-design/deploys/5d1b3a682c7df100093de5f9

@codecov

This comment has been minimized.

Copy link

commented Jul 2, 2019

Codecov Report

Merging #17412 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17412      +/-   ##
==========================================
+ Coverage   96.03%   96.07%   +0.04%     
==========================================
  Files         267      267              
  Lines        7416     7416              
  Branches     2066     2068       +2     
==========================================
+ Hits         7122     7125       +3     
+ Misses        292      289       -3     
  Partials        2        2
Impacted Files Coverage Δ
components/form/Form.tsx 91.3% <ø> (ø) ⬆️
components/_util/wave.tsx 88.67% <0%> (+2.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f096b89...32132c5. Read the comment docs.

@afc163 afc163 merged commit 6429172 into master Jul 2, 2019

27 of 29 checks passed

Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 217 new files uploaded
Details
DEP All dependencies are resolved
LGTM analysis: JavaScript No new or fixed alerts
Details
License Compliance All checks passed.
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing f096b89...32132c5
Details
codecov/project 96.07% (+0.04%) compared to f096b89
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Jul 2, 2019

@delete-merged-branch delete-merged-branch bot deleted the fix-form-onSubmit-type branch Jul 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.