Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DatePicker's input box is obscured on safari #17421

Merged
merged 1 commit into from Jul 3, 2019

Conversation

Projects
None yet
2 participants
@justjavac
Copy link
Contributor

commented Jul 3, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

👻 What's the background?

💡 Solution

The input style defines height and line-height as 32px, and the DatePicker component re-sets height to 20px(by @input-height-sm), but forgot to define line-height.

📝 Changelog

Language Changelog
🇺🇸 English 🐞 Fix DatePicker's input box is obscured on safari.
🇨🇳 Chinese 🐞 修复 safari 浏览器 DatePicker 组件输入框被遮挡的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label Jul 3, 2019

@netlify

This comment has been minimized.

Copy link

commented Jul 3, 2019

Deploy preview for ant-design ready!

Built with commit f78fc1c

https://deploy-preview-17421--ant-design.netlify.com

@buildsize

This comment has been minimized.

Copy link

commented Jul 3, 2019

File name Previous Size New Size Change
package-lock.json 833.41 KB 858.1 KB 24.69 KB (3%)
@codecov

This comment has been minimized.

Copy link

commented Jul 3, 2019

Codecov Report

Merging #17421 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17421      +/-   ##
==========================================
- Coverage   96.03%   95.95%   -0.08%     
==========================================
  Files         267      263       -4     
  Lines        7416     7351      -65     
  Branches     2055     2053       -2     
==========================================
- Hits         7122     7054      -68     
- Misses        292      295       +3     
  Partials        2        2
Impacted Files Coverage Δ
components/form/FormItem.tsx 97.15% <0%> (-1.71%) ⬇️
components/descriptions/index.tsx 98.66% <0%> (-0.27%) ⬇️
components/tooltip/index.tsx 96.47% <0%> (-0.05%) ⬇️
components/upload/UploadList.tsx 96.51% <0%> (-0.05%) ⬇️
components/switch/index.tsx 100% <0%> (ø) ⬆️
components/popconfirm/index.tsx 100% <0%> (ø) ⬆️
components/tree/Tree.tsx 96.87% <0%> (ø) ⬆️
components/progress/Circle.tsx 100% <0%> (ø) ⬆️
components/checkbox/Group.tsx 100% <0%> (ø) ⬆️
components/result/noFound.tsx
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6429172...f78fc1c. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

commented Jul 3, 2019

Codecov Report

Merging #17421 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17421      +/-   ##
==========================================
- Coverage   96.03%   95.95%   -0.08%     
==========================================
  Files         267      263       -4     
  Lines        7416     7351      -65     
  Branches     2055     2053       -2     
==========================================
- Hits         7122     7054      -68     
- Misses        292      295       +3     
  Partials        2        2
Impacted Files Coverage Δ
components/form/FormItem.tsx 97.15% <0%> (-1.71%) ⬇️
components/descriptions/index.tsx 98.66% <0%> (-0.27%) ⬇️
components/tooltip/index.tsx 96.47% <0%> (-0.05%) ⬇️
components/upload/UploadList.tsx 96.51% <0%> (-0.05%) ⬇️
components/switch/index.tsx 100% <0%> (ø) ⬆️
components/popconfirm/index.tsx 100% <0%> (ø) ⬆️
components/tree/Tree.tsx 96.87% <0%> (ø) ⬆️
components/progress/Circle.tsx 100% <0%> (ø) ⬆️
components/checkbox/Group.tsx 100% <0%> (ø) ⬆️
components/result/noFound.tsx
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6429172...f78fc1c. Read the comment docs.

@afc163 afc163 merged commit 73d173d into ant-design:master Jul 3, 2019

25 of 28 checks passed

Header rules - ant-design No header rules processed
Details
LGTM analysis: JavaScript No code changes detected
Details
Pages changed - ant-design 217 new files uploaded
Details
DEP All dependencies are resolved
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize Significant change of package-lock.json up by 24.69 KB (2.96%)
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 6429172...f78fc1c
Details
codecov/project 95.95% (-0.08%) compared to 6429172
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No new issues
Details

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Jul 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.