Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: icon typo #17458

Merged
merged 3 commits into from Jul 4, 2019

Conversation

Projects
None yet
2 participants
@afc163
Copy link
Member

commented Jul 4, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

👻 What's the background?

close #17448

💡 Solution

📝 Changelog

Language Changelog
🇺🇸 English Fix typo icon name colum-height to column-height.
🇨🇳 Chinese 修复图标名 colum-height 为 column-height。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label Jul 4, 2019

@tests-checker
Copy link

left a comment

Could you please add tests to make sure this change works as expected?

@netlify

This comment has been minimized.

Copy link

commented Jul 4, 2019

Deploy preview for ant-design ready!

Built with commit f63b9e7

https://deploy-preview-17458--ant-design.netlify.com

@afc163 afc163 force-pushed the fix-icon-typo branch from 426a586 to f9fde11 Jul 4, 2019

@codecov

This comment has been minimized.

Copy link

commented Jul 4, 2019

Codecov Report

Merging #17458 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17458      +/-   ##
==========================================
- Coverage   96.03%   95.99%   -0.04%     
==========================================
  Files         267      267              
  Lines        7416     7419       +3     
  Branches     2066     2056      -10     
==========================================
  Hits         7122     7122              
- Misses        292      295       +3     
  Partials        2        2
Impacted Files Coverage Δ
components/icon/utils.ts 93.02% <0%> (-6.98%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 859bba5...f63b9e7. Read the comment docs.

@afc163 afc163 referenced this pull request Jul 4, 2019

Closed

chore: Update snapshot #17463

1 of 10 tasks complete

@afc163 afc163 force-pushed the fix-icon-typo branch from 3c790be to f63b9e7 Jul 4, 2019

@zombieJ zombieJ merged commit b1e63be into master Jul 4, 2019

24 of 27 checks passed

License Compliance FOSSA is analyzing this commit
Details
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 217 new files uploaded
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (ant-design) Test PR is disabled for this project
security/snyk - package.json (paranoidjk) No new issues
Details

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Jul 4, 2019

@delete-merged-branch delete-merged-branch bot deleted the fix-icon-typo branch Jul 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.