Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: icon typo #17458

Merged
merged 3 commits into from Jul 4, 2019
Merged

fix: icon typo #17458

merged 3 commits into from Jul 4, 2019

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Jul 4, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

👻 What's the background?

close #17448

💡 Solution

📝 Changelog

Language Changelog
🇺🇸 English Fix typo icon name colum-height to column-height.
🇨🇳 Chinese 修复图标名 colum-heightcolumn-height

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@netlify
Copy link

netlify bot commented Jul 4, 2019

Deploy preview for ant-design ready!

Built with commit f63b9e7

https://deploy-preview-17458--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Jul 4, 2019

Codecov Report

Merging #17458 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17458      +/-   ##
==========================================
- Coverage   96.03%   95.99%   -0.04%     
==========================================
  Files         267      267              
  Lines        7416     7419       +3     
  Branches     2066     2056      -10     
==========================================
  Hits         7122     7122              
- Misses        292      295       +3     
  Partials        2        2
Impacted Files Coverage Δ
components/icon/utils.ts 93.02% <0%> (-6.98%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 859bba5...f63b9e7. Read the comment docs.

@afc163 afc163 mentioned this pull request Jul 4, 2019
10 tasks
@zombieJ zombieJ merged commit b1e63be into master Jul 4, 2019
26 of 27 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix-icon-typo branch Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants