Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 💄 change DatePicker arrow style #17480

Merged
merged 1 commit into from Jul 5, 2019

Conversation

Projects
None yet
1 participant
@afc163
Copy link
Member

commented Jul 4, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

👻 What's the background?

更换一种箭头样式实现方式,解决非 utf-8 编码下箭头样式乱码的问题。

close #17334
close #15365

💡 Solution

用伪元素的边框加转向来实现。

效果:

图片

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese 优化 DatePicker 箭头样式,解决非 utf-8 编码下箭头样式乱码的问题

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label Jul 4, 2019

@netlify

This comment has been minimized.

Copy link

commented Jul 4, 2019

Deploy preview for ant-design ready!

Built with commit 6498cbb

https://deploy-preview-17480--ant-design.netlify.com

@afc163 afc163 force-pushed the change-date-picker-arrow branch from e274dbd to a46c2f7 Jul 4, 2019

@afc163 afc163 force-pushed the change-date-picker-arrow branch from a46c2f7 to 6498cbb Jul 4, 2019

@buildsize

This comment has been minimized.

Copy link

commented Jul 4, 2019

File name Previous Size New Size Change
package-lock.json 833.41 KB 834.61 KB 1.19 KB (0%)
@afc163

This comment has been minimized.

Copy link
Member Author

commented Jul 5, 2019

用例莫名其妙都挂了。

@afc163 afc163 merged commit 5375bf0 into master Jul 5, 2019

13 of 27 checks passed

ant-design.ant-design #ant design failed
Details
ci/circleci: test_dist Your tests failed on CircleCI
Details
ci/circleci: test_dist_15 Your tests failed on CircleCI
Details
ci/circleci: test_dom Your tests failed on CircleCI
Details
ci/circleci: test_dom_15 Your tests failed on CircleCI
Details
ci/circleci: test_es Your tests failed on CircleCI
Details
ci/circleci: test_es_15 Your tests failed on CircleCI
Details
ci/circleci: test_lib Your tests failed on CircleCI
Details
ci/circleci: test_lib_15 Your tests failed on CircleCI
Details
ci/circleci: test_node Your tests failed on CircleCI
Details
ci/circleci: test_node_15 Your tests failed on CircleCI
Details
Header rules - ant-design No header rules processed
Details
LGTM analysis: JavaScript No code changes detected
Details
Pages changed - ant-design 217 new files uploaded
Details
License Compliance Analysis timed out. Check FOSSA for updates.
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
buildsize No change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (ant-design) Test PR is disabled for this project
security/snyk - package.json (paranoidjk) No manifest changes detected

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Jul 5, 2019

@delete-merged-branch delete-merged-branch bot deleted the change-date-picker-arrow branch Jul 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.