Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: some tabs style #17500

Merged
merged 2 commits into from Jul 7, 2019

Conversation

Projects
None yet
2 participants
@afc163
Copy link
Member

commented Jul 6, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

👻 What's the background?

close #17477
close #17468

💡 Solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Tabs disabled tab and next icon style.
🇨🇳 Chinese 修复 Tabs 当前失效页签样式以及切换图标错位 2px 的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

afc163 added some commits Jul 6, 2019

@pr-triage pr-triage bot added the PR: unreviewed label Jul 6, 2019

@netlify

This comment has been minimized.

Copy link

commented Jul 6, 2019

Deploy preview for ant-design ready!

Built with commit b4102c9

https://deploy-preview-17500--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Jul 6, 2019

Codecov Report

Merging #17500 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17500      +/-   ##
==========================================
- Coverage   96.07%   96.03%   -0.05%     
==========================================
  Files         267      267              
  Lines        7419     7419              
  Branches     2067     2067              
==========================================
- Hits         7128     7125       -3     
- Misses        289      292       +3     
  Partials        2        2
Impacted Files Coverage Δ
components/_util/wave.tsx 85.84% <0%> (-2.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5375bf0...b4102c9. Read the comment docs.

@yutingzhao1991 yutingzhao1991 requested a review from zombieJ Jul 6, 2019

@zombieJ zombieJ merged commit 1d2bc07 into master Jul 7, 2019

26 of 29 checks passed

Header rules - ant-design No header rules processed
Details
LGTM analysis: JavaScript No code changes detected
Details
Pages changed - ant-design 219 new files uploaded
Details
DEP All dependencies are resolved
License Compliance All checks passed.
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No prior size to compare - 841.53 KB
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 5375bf0...b4102c9
Details
codecov/project 96.03% (-0.05%) compared to 5375bf0
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Jul 7, 2019

@delete-merged-branch delete-merged-branch bot deleted the fix-tabs-style branch Jul 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.