Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Anchor): add getCurrentAnchor prop #17823

Merged
merged 5 commits into from Aug 16, 2019

Conversation

@shaodahong
Copy link
Collaborator

commented Jul 23, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#17665

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Customize the anchor highlight
🇨🇳 Chinese 自定义锚点高亮

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/anchor/demo/customizeHighlight.md
View rendered components/anchor/index.en-US.md
View rendered components/anchor/index.zh-CN.md

@pr-triage pr-triage bot added the PR: unreviewed label Jul 23, 2019

@tests-checker
Copy link

left a comment

Could you please add tests to make sure this change works as expected?

@netlify

This comment has been minimized.

Copy link

commented Jul 23, 2019

Deploy preview for ant-design ready!

Built with commit 23c4fa8

https://deploy-preview-17823--ant-design.netlify.com

@shaodahong shaodahong referenced this pull request Jul 23, 2019
1 of 1 task complete
@shaodahong

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 23, 2019

@zombieJ Please check this pr

@codecov

This comment has been minimized.

Copy link

commented Jul 23, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (feature@161def0). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             feature   #17823   +/-   ##
==========================================
  Coverage           ?   96.12%           
==========================================
  Files              ?      271           
  Lines              ?     7477           
  Branches           ?     2096           
==========================================
  Hits               ?     7187           
  Misses             ?      288           
  Partials           ?        2
Impacted Files Coverage Δ
components/anchor/Anchor.tsx 90.9% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 161def0...23c4fa8. Read the comment docs.

@zombieJ

This comment has been minimized.

Copy link
Member

commented Jul 23, 2019

feature branch ...

Not master : )

@shaodahong shaodahong changed the base branch from master to feature Jul 23, 2019

@shaodahong

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 23, 2019

切成 feature

@zombieJ

This comment has been minimized.

Copy link
Member

commented Jul 23, 2019

Approved. @afc163 @ztplz please help to double confirm.

@shaodahong shaodahong referenced this pull request Jul 24, 2019
5 of 14 tasks complete

@afc163 afc163 merged commit 4e26107 into ant-design:feature Aug 16, 2019

25 of 27 checks passed

Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 217 new files uploaded
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch No report found to compare against
Details
codecov/project No report found to compare against
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.