Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Anchor): add getCurrentAnchor prop #17823

Merged
merged 5 commits into from Aug 16, 2019
Merged

feat(Anchor): add getCurrentAnchor prop #17823

merged 5 commits into from Aug 16, 2019

Conversation

shaodahong
Copy link
Member

@shaodahong shaodahong commented Jul 23, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#17665

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Customize the anchor highlight
🇨🇳 Chinese 自定义锚点高亮

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/anchor/demo/customizeHighlight.md
View rendered components/anchor/index.en-US.md
View rendered components/anchor/index.zh-CN.md

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@netlify
Copy link

netlify bot commented Jul 23, 2019

Deploy preview for ant-design ready!

Built with commit 23c4fa8

https://deploy-preview-17823--ant-design.netlify.com

@shaodahong
Copy link
Member Author

shaodahong commented Jul 23, 2019

@zombieJ Please check this pr

@codecov
Copy link

codecov bot commented Jul 23, 2019

Codecov Report

No coverage uploaded for pull request base (feature@161def0). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             feature   #17823   +/-   ##
==========================================
  Coverage           ?   96.12%           
==========================================
  Files              ?      271           
  Lines              ?     7477           
  Branches           ?     2096           
==========================================
  Hits               ?     7187           
  Misses             ?      288           
  Partials           ?        2
Impacted Files Coverage Δ
components/anchor/Anchor.tsx 90.9% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 161def0...23c4fa8. Read the comment docs.

components/anchor/index.en-US.md Outdated Show resolved Hide resolved
@zombieJ
Copy link
Member

zombieJ commented Jul 23, 2019

feature branch ...

Not master : )

@shaodahong shaodahong changed the base branch from master to feature Jul 23, 2019
@shaodahong
Copy link
Member Author

shaodahong commented Jul 23, 2019

切成 feature

@zombieJ
Copy link
Member

zombieJ commented Jul 23, 2019

Approved. @afc163 @ztplz please help to double confirm.

@afc163 afc163 merged commit 4e26107 into ant-design:feature Aug 16, 2019
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants