Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: steps component support type navigation #17994

Merged
merged 17 commits into from Aug 14, 2019

Conversation

@yutingzhao1991
Copy link
Contributor

commented Jul 31, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

#17814

馃挕 Background and solution

add type to support new style:

image

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English Step support type prop to set navigation for new style
馃嚚馃嚦 Chinese Step 鏀寔 type 灞炴ц缃负 navigation 鏉ユ敮鎸佹柊鐨勫鑸楠ゆ潯鏍峰紡

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
  • wait for react-component/steps#75

View rendered components/steps/demo/nav.md
View rendered components/steps/index.en-US.md
View rendered components/steps/index.zh-CN.md

@yutingzhao1991 yutingzhao1991 requested a review from zombieJ Jul 31, 2019

@netlify

This comment has been minimized.

Copy link

commented Jul 31, 2019

Deploy preview for ant-design ready!

Built with commit fab9445

https://deploy-preview-17994--ant-design.netlify.com

components/steps/demo/nav.md Outdated Show resolved Hide resolved
components/steps/demo/nav.md Outdated Show resolved Hide resolved
@afc163

This comment has been minimized.

Copy link
Member

commented Jul 31, 2019

image

鍙充晶 padding 鍜岃璁$ǹ瀵逛笉涓娿

components/steps/demo/nav.md Outdated Show resolved Hide resolved
@zombieJ

This comment has been minimized.

Copy link
Member

commented Jul 31, 2019

杩欎釜 Steps 鐨勪氦浜掓槸涓嶆槸涓嶅お瀵癸紵鐐瑰嚮搴旇鏄珮浜 active锛屼笉鏄 current锛

@yutingzhao1991

This comment has been minimized.

Copy link
Contributor Author

commented Aug 1, 2019

杩欎釜 Steps 鐨勪氦浜掓槸涓嶆槸涓嶅お瀵癸紵鐐瑰嚮搴旇鏄珮浜 active锛屼笉鏄 current锛

鐜板湪鐨勯昏緫灏辨槸 current 鐨 step 灏辨槸 active 鐨 step銆傝繖閲屾湁涓鐐硅璇存槑鐨勬槸锛岄氬父瀵逛簬杩欑瀵艰埅绫荤殑姝ラ锛岀敤鎴峰簲璇ュ埗瀹 step 鐨 status锛岃屼笉鏄娇鐢ㄩ粯璁ょ殑閫昏緫锛堥粯璁ら昏緫鏄氳繃 current 鏉ヨ瀹氱殑锛夈

@yutingzhao1991

This comment has been minimized.

Copy link
Contributor Author

commented Aug 1, 2019

image

@yutingzhao1991 yutingzhao1991 changed the title [WIP] feat: steps component support type nav feat: steps component support type nav Aug 2, 2019

@pr-triage pr-triage bot added the PR: unreviewed label Aug 2, 2019

@buildsize

This comment has been minimized.

Copy link

commented Aug 2, 2019

File name Previous Size New Size Change
package-lock.json 817.42聽KB 863.04聽KB 45.62聽KB (6%)
@codecov

This comment has been minimized.

Copy link

commented Aug 2, 2019

Codecov Report

Merging #17994 into feature will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #17994   +/-   ##
========================================
  Coverage    96.16%   96.16%           
========================================
  Files          278      278           
  Lines         7531     7531           
  Branches      2080     2094   +14     
========================================
  Hits          7242     7242           
  Misses         287      287           
  Partials         2        2
Impacted Files Coverage 螖
components/steps/index.tsx 100% <酶> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 64dbcc5...fab9445. Read the comment docs.

@yutingzhao1991 yutingzhao1991 requested a review from ikobe Aug 2, 2019

@yutingzhao1991 yutingzhao1991 changed the base branch from feature to master Aug 2, 2019

@yutingzhao1991 yutingzhao1991 changed the title feat: steps component support type nav feat: steps component support type navigation Aug 2, 2019

@zombieJ

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

鎰熻宸笉澶氫簡 @afc163

@yutingzhao1991 yutingzhao1991 changed the base branch from master to feature Aug 6, 2019

@afc163

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

image

Firefox 涓嬪彉鎴愯繖鏍蜂簡銆

@yutingzhao1991

This comment has been minimized.

Copy link
Contributor Author

commented Aug 8, 2019

@afc163 firefox 鐨勯棶棰樹慨澶嶄簡銆

components/steps/index.en-US.md Outdated Show resolved Hide resolved
components/steps/index.zh-CN.md Outdated Show resolved Hide resolved

@zombieJ zombieJ merged commit 2d2d9f6 into feature Aug 14, 2019

26 of 28 checks passed

Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 221 new files uploaded
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
License Compliance All checks passed.
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No significant change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 64dbcc5...fab9445
Details
codecov/project 96.16% remains the same compared to 64dbcc5
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No new issues
Details

@zombieJ zombieJ deleted the feat/step branch Aug 14, 2019

@afc163

This comment has been minimized.

Copy link
Member

commented Aug 17, 2019

杈规涓嶅唴寤哄湪缁勪欢鏍峰紡閲屼箞锛屾寜鎴戠殑鐞嗚В搴旇鍜 Tabs 涓鏍烽粯璁ゆ湁涓嬭竟妗嗐

@mingyang11

This comment has been minimized.

Copy link

commented Aug 19, 2019

浣犲ソ锛屾湁娌℃湁姝ラ鏉″洜涓烘楠ゆ暟閲忓お澶氳岃嚜鍔ㄦ姌琛屽埌绗簩琛屽睍绀虹殑妗堜緥

@afc163 afc163 referenced this pull request Aug 20, 2019
0 of 1 task complete
afc163 added a commit that referenced this pull request Aug 20, 2019
@afc163 afc163 referenced this pull request Aug 20, 2019
5 of 14 tasks complete
afc163 added a commit that referenced this pull request Aug 20, 2019
@afc163 afc163 referenced this pull request Aug 21, 2019
5 of 14 tasks complete
lewis617 pushed a commit to lewis617/ant-design that referenced this pull request Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can鈥檛 perform that action at this time.