Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃敟feat: new pageheader style #18128

Merged
merged 22 commits into from Aug 25, 2019

Conversation

@chenshuai2144
Copy link
Contributor

commented Aug 6, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

no

馃挕 Background and solution

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English PageHeader style update
馃嚚馃嚦 Chinese PageHeader 鏍峰紡浼樺寲

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/page-header/demo/actions.md
View rendered components/page-header/index.zh-CN.md

@pr-triage pr-triage bot added the PR: draft label Aug 6, 2019

@netlify

This comment has been minimized.

Copy link

commented Aug 6, 2019

Deploy preview for ant-design ready!

Built with commit 3c7404e

https://deploy-preview-18128--ant-design.netlify.com

@chenshuai2144

This comment has been minimized.

Copy link
Contributor Author

commented Aug 7, 2019

鍙樺緱鍜 pro 鐨勫ソ鍍
缂栫粍 6

@buildsize

This comment has been minimized.

Copy link

commented Aug 11, 2019

File name Previous Size New Size Change
package-lock.json 835.83聽KB 832.98聽KB -2.84聽KB (0%)

@chenshuai2144 chenshuai2144 force-pushed the pageheader branch from ea50b89 to c5ce712 Aug 12, 2019

@codecov

This comment has been minimized.

Copy link

commented Aug 13, 2019

Codecov Report

Merging #18128 into feature will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #18128      +/-   ##
===========================================
+ Coverage    96.22%   96.23%   +<.01%     
===========================================
  Files          280      280              
  Lines         7533     7542       +9     
  Branches      2098     2056      -42     
===========================================
+ Hits          7249     7258       +9     
  Misses         282      282              
  Partials         2        2
Impacted Files Coverage 螖
components/page-header/index.tsx 100% <100%> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update f9f6e8d...3c7404e. Read the comment docs.

@chenshuai2144 chenshuai2144 force-pushed the pageheader branch from af4dbce to bcd8f25 Aug 16, 2019

@chenshuai2144 chenshuai2144 marked this pull request as ready for review Aug 16, 2019

@pr-triage pr-triage bot added PR: unreviewed and removed PR: draft labels Aug 16, 2019

@chenshuai2144 chenshuai2144 force-pushed the pageheader branch from 7aa4ac6 to eb6b2f8 Aug 17, 2019

@chenshuai2144 chenshuai2144 force-pushed the pageheader branch from eb6b2f8 to f99a1b1 Aug 21, 2019

@chenshuai2144 chenshuai2144 referenced this pull request Aug 25, 2019
5 of 14 tasks complete

@chenshuai2144 chenshuai2144 changed the title feat: new pageheader style 馃敟feat: new pageheader style Aug 25, 2019

@ztplz
ztplz approved these changes Aug 25, 2019

@chenshuai2144 chenshuai2144 merged commit e737e50 into feature Aug 25, 2019

27 of 30 checks passed

Build
Details
Semantic Pull Request add a semantic commit or PR title
Details
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 215 new files uploaded
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
License Compliance All checks passed.
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize Significant change of package-lock.json down by 2.84聽KB (0.34%)
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 96.22%)
Details
codecov/project 96.23% (+<.01%) compared to f9f6e8d
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@chenshuai2144 chenshuai2144 deleted the pageheader branch Aug 25, 2019

@dengfuping dengfuping referenced this pull request Sep 3, 2019
1 of 14 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can鈥檛 perform that action at this time.