Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added support for Romanian locale #18163

Merged
merged 1 commit into from Aug 8, 2019
Merged

feat: Added support for Romanian locale #18163

merged 1 commit into from Aug 8, 2019

Conversation

stefy
Copy link
Contributor

@stefy stefy commented Aug 8, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

馃挕 Background and solution

Added support for Romanian locale

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English Added support for Romanian locale
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered docs/react/i18n.en-US.md
View rendered docs/react/i18n.zh-CN.md

@netlify
Copy link

netlify bot commented Aug 8, 2019

Deploy preview for ant-design ready!

Built with commit 1933f1d

https://deploy-preview-18163--ant-design.netlify.com

@buildsize
Copy link

buildsize bot commented Aug 8, 2019

File name Previous Size New Size Change
package-lock.json 817.42聽KB 820.79聽KB 3.37聽KB (0%)

docs/react/i18n.zh-CN.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 8, 2019

Codecov Report

Merging #18163 into feature will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #18163      +/-   ##
===========================================
+ Coverage    96.15%   96.15%   +<.01%     
===========================================
  Files          276      278       +2     
  Lines         7509     7511       +2     
  Branches      2104     2060      -44     
===========================================
+ Hits          7220     7222       +2     
  Misses         287      287              
  Partials         2        2
Impacted Files Coverage 螖
components/time-picker/locale/ro_RO.tsx 100% <100%> (酶)
components/date-picker/locale/ro_RO.tsx 100% <100%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update a6215da...1933f1d. Read the comment docs.

@afc163 afc163 changed the title Added support for Romanian locale feat: Added support for Romanian locale Aug 8, 2019
afc163
afc163 previously approved these changes Aug 8, 2019
@afc163
Copy link
Member

afc163 commented Aug 8, 2019

Please add test case like other language and update snapshots.

https://ant.design/docs/react/contributing#Sending-a-Pull-Request

@stefy
Copy link
Contributor Author

stefy commented Aug 8, 2019

Please add test case like other language and update snapshots.

https://ant.design/docs/react/contributing#Sending-a-Pull-Request

Added test cases for Romanian locales and updated the snapshots. Thanks!

afc163
afc163 approved these changes Aug 8, 2019
@afc163 afc163 merged commit a5a8f38 into ant-design:feature Aug 8, 2019
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants