Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Tree support virtual scroll #18172

Merged
merged 22 commits into from Aug 12, 2019
Merged

feat: Tree support virtual scroll #18172

merged 22 commits into from Aug 12, 2019

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Aug 8, 2019

Preview

https://deploy-preview-18172--ant-design.netlify.com/components/tree-cn/#header

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

ref #16911

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Tree support virtual scroll.
🇨🇳 Chinese Tree 支持虚拟滚动。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/tree/demo/basic.md

@todo
Copy link

@todo todo bot commented Aug 8, 2019

block node

// TODO: block node


This comment was generated by todo based on a TODO comment in 001e73e in #18172. cc @ant-design.

@netlify
Copy link

@netlify netlify bot commented Aug 8, 2019

Deploy preview for ant-design ready!

Built with commit 015bf17

https://deploy-preview-18172--ant-design.netlify.com

@zombieJ zombieJ changed the title feat: Tree support virtual scroll [WIP] feat: Tree support virtual scroll Aug 8, 2019
@pr-triage pr-triage bot removed the PR: unreviewed label Aug 8, 2019
@zombieJ zombieJ added the 4.x label Aug 8, 2019
@buildsize
Copy link

@buildsize buildsize bot commented Aug 8, 2019

File name Previous Size New Size Change
package-lock.json 819.9 KB 827.27 KB 7.37 KB (1%)

components/tree/DirectoryTree.tsx Outdated Show resolved Hide resolved
components/tree/Tree.tsx Outdated Show resolved Hide resolved
@codecov
Copy link

@codecov codecov bot commented Aug 12, 2019

Codecov Report

Merging #18172 into 4.0-prepare will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           4.0-prepare   #18172      +/-   ##
===============================================
- Coverage        96.13%   96.09%   -0.05%     
===============================================
  Files              280      280              
  Lines             7483     7482       -1     
  Branches          2085     2089       +4     
===============================================
- Hits              7194     7190       -4     
- Misses             287      290       +3     
  Partials             2        2
Impacted Files Coverage Δ
components/form/FormList.tsx 100% <ø> (ø) ⬆️
components/tree/Tree.tsx 96.87% <ø> (ø) ⬆️
components/form/FormItemInput.tsx 94.28% <ø> (ø) ⬆️
components/tree/util.ts 95.12% <100%> (-0.44%) ⬇️
components/tree/DirectoryTree.tsx 97.87% <100%> (+0.07%) ⬆️
components/_util/wave.tsx 85.57% <0%> (-2.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b30dc1c...015bf17. Read the comment docs.

@zombieJ zombieJ changed the title [WIP] feat: Tree support virtual scroll feat: Tree support virtual scroll Aug 12, 2019
afc163
afc163 approved these changes Aug 12, 2019
@zombieJ zombieJ merged commit 8114516 into 4.0-prepare Aug 12, 2019
24 checks passed
@zombieJ zombieJ deleted the virtual-tree branch Aug 12, 2019
@pr-triage pr-triage bot added the PR: merged label Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants