Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update ts define #18196

Merged
merged 1 commit into from Aug 10, 2019

Conversation

@zombieJ
Copy link
Member

commented Aug 10, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

屏幕快照 2019-08-10 下午12 38 03

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Upload.Dragger typescript definition.
🇨🇳 Chinese 修复 Upload.Dragger typescript 定义。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label Aug 10, 2019

@netlify

This comment has been minimized.

Copy link

commented Aug 10, 2019

Deploy preview for ant-design ready!

Built with commit 3ee5da2

https://deploy-preview-18196--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Aug 10, 2019

Codecov Report

Merging #18196 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18196   +/-   ##
=======================================
  Coverage   96.28%   96.28%           
=======================================
  Files         276      276           
  Lines        7520     7520           
  Branches     2089     2089           
=======================================
  Hits         7241     7241           
  Misses        277      277           
  Partials        2        2
Impacted Files Coverage Δ
components/upload/Dragger.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 729744b...3ee5da2. Read the comment docs.

@zombieJ zombieJ merged commit 286538f into master Aug 10, 2019

27 of 29 checks passed

Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 214 new files uploaded
Details
DEP All dependencies are resolved
LGTM analysis: JavaScript No new or fixed alerts
Details
License Compliance All checks passed.
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 96.28%)
Details
codecov/project 96.28% (+0%) compared to 729744b
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@zombieJ zombieJ deleted the fix-dragger-ts branch Aug 10, 2019

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Aug 10, 2019

@afc163

This comment has been minimized.

Copy link
Member

commented Aug 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.