Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛Button loading prop warning #18208

Merged
merged 1 commit into from Aug 11, 2019
Merged

fix: 🐛Button loading prop warning #18208

merged 1 commit into from Aug 11, 2019

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Aug 11, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #18205

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Button received false for a non-boolean attribute loading warning.
🇨🇳 Chinese 修复一个 Button received false for a non-boolean attribute loading 警告信息。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Aug 11, 2019

Deploy preview for ant-design ready!

Built with commit 389533c

https://deploy-preview-18208--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Aug 11, 2019

Codecov Report

Merging #18208 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18208      +/-   ##
==========================================
- Coverage   96.32%   96.28%   -0.04%     
==========================================
  Files         276      276              
  Lines        7520     7520              
  Branches     2092     2092              
==========================================
- Hits         7244     7241       -3     
- Misses        274      277       +3     
  Partials        2        2
Impacted Files Coverage Δ
components/button/button.tsx 93.96% <100%> (ø) ⬆️
components/_util/wave.tsx 85.57% <0%> (-2.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33a5da4...389533c. Read the comment docs.

@afc163 afc163 merged commit aa2ed79 into master Aug 11, 2019
23 checks passed
@afc163 afc163 deleted the fix-button-loading branch Aug 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button received false for a non-boolean attribute loading
1 participant