Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 馃啓 upgrade react-slick and eslint-config-airbnb #18209

Merged
merged 8 commits into from Aug 12, 2019

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Aug 11, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

馃挕 Background and solution

  • Upgrade react-slick to resolve react 16.9 warning.
  • Upgrade eslint-config-airbnb

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@netlify
Copy link

netlify bot commented Aug 11, 2019

Deploy preview for ant-design ready!

Built with commit 9095189

https://deploy-preview-18209--ant-design.netlify.com

@@ -56,6 +56,8 @@ const eslintrc = {
'jsx-a11y/anchor-is-valid': 0,
'comma-dangle': ['error', 'always-multiline'],
'react/jsx-filename-extension': 0,
'react/state-in-constructor': 0,
Copy link
Member Author

@afc163 afc163 Aug 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

杩欎釜鎰熻鏄簲璇ヨ鏀规帀鐨勶紝contructor 閲岄潰閫氳繃 props 鍙 state 鍒濆鍊肩殑閫昏緫閮藉彲浠ュ悎骞跺埌 getDerivedStateFromProps 閲屻

@buildsize
Copy link

buildsize bot commented Aug 11, 2019

File name Previous Size New Size Change
package-lock.json 825.97聽KB 827.53聽KB 1.56聽KB (0%)

@afc163 afc163 changed the title chore: 猡达笍 upgrade eslint-config-airbnb chore: 猡达笍 upgrade react-slick and eslint-config-airbnb Aug 11, 2019
@afc163 afc163 changed the title chore: 猡达笍 upgrade react-slick and eslint-config-airbnb chore: 馃啓upgrade react-slick and eslint-config-airbnb Aug 11, 2019
@afc163 afc163 changed the title chore: 馃啓upgrade react-slick and eslint-config-airbnb chore: 馃啓 upgrade react-slick and eslint-config-airbnb Aug 11, 2019
package.json Outdated
@@ -90,7 +90,7 @@
"rc-util": "^4.6.0",
"react-lazy-load": "^3.0.13",
"react-lifecycles-compat": "^3.0.4",
"react-slick": "~0.24.0",
"react-slick": "~0.25.0",
Copy link
Member Author

@afc163 afc163 Aug 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov
Copy link

codecov bot commented Aug 11, 2019

Codecov Report

Merging #18209 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18209      +/-   ##
==========================================
- Coverage   96.32%   96.28%   -0.04%     
==========================================
  Files         276      276              
  Lines        7520     7520              
  Branches     2048     2048              
==========================================
- Hits         7244     7241       -3     
- Misses        274      277       +3     
  Partials        2        2
Impacted Files Coverage 螖
components/_util/throttleByAnimationFrame.tsx 95.45% <酶> (酶) 猬嗭笍
components/modal/ActionButton.tsx 90% <酶> (酶) 猬嗭笍
components/form/Form.tsx 91.3% <100%> (酶) 猬嗭笍
components/modal/index.tsx 100% <100%> (酶) 猬嗭笍
components/carousel/index.tsx 96.55% <100%> (酶) 猬嗭笍
components/_util/wave.tsx 85.57% <0%> (-2.89%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 090afe0...9095189. Read the comment docs.

@afc163
Copy link
Member Author

afc163 commented Aug 11, 2019

@afc163 afc163 merged commit b0c5a3b into master Aug 12, 2019
20 checks passed
@afc163 afc163 deleted the eslint-config-airbnb branch Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant