Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: descriptions style update #18270

Merged
merged 5 commits into from Aug 16, 2019

Conversation

@chenshuai2144
Copy link
Contributor

commented Aug 14, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

descriptions 非 border 模式下 的 padding 不会跟着 size 走。在 pageheader 中 16 有点大。但是不能用 border 模式。这个 pr 修复了这个问题

📝 Changelog

Language Changelog
🇺🇸 English The size of Descriptions now controls the padding-bottom of Descriptions.Item
🇨🇳 Chinese Descriptions 的 size 现在会控制 Descriptions.Item 的 padding-bottom

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/steps/demo/nav.md
View rendered components/steps/demo/simple.md
View rendered components/steps/index.en-US.md
View rendered components/steps/index.zh-CN.md
View rendered docs/react/i18n.en-US.md
View rendered docs/react/i18n.zh-CN.md

@pr-triage pr-triage bot added the PR: unreviewed label Aug 14, 2019

@tests-checker
Copy link

left a comment

Could you please add tests to make sure this change works as expected?

@netlify

This comment has been minimized.

Copy link

commented Aug 14, 2019

Deploy preview for ant-design ready!

Built with commit 515a4d6

https://deploy-preview-18270--ant-design.netlify.com

@chenshuai2144 chenshuai2144 changed the base branch from master to feature Aug 14, 2019

@afc163

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

Descriptions的 size 将会控制 item 的 padding-bottom

这个 changelog 有点看不懂。

💡 Background and solution

写一下解决什么问题。

@zombieJ

This comment has been minimized.

Copy link
Member

commented Aug 15, 2019

@chenshuai2144 chenshuai2144 force-pushed the descript-style branch from 71df5fa to af03100 Aug 15, 2019

@codecov

This comment has been minimized.

Copy link

commented Aug 15, 2019

Codecov Report

Merging #18270 into feature will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #18270      +/-   ##
===========================================
- Coverage    96.33%   96.29%   -0.04%     
===========================================
  Files          278      278              
  Lines         7529     7529              
  Branches      2077     2091      +14     
===========================================
- Hits          7253     7250       -3     
- Misses         274      277       +3     
  Partials         2        2
Impacted Files Coverage Δ
components/_util/wave.tsx 85.57% <0%> (-2.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19fc777...515a4d6. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

commented Aug 15, 2019

Codecov Report

Merging #18270 into feature will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #18270      +/-   ##
===========================================
- Coverage    96.33%   96.29%   -0.04%     
===========================================
  Files          278      278              
  Lines         7529     7529              
  Branches      2077     2091      +14     
===========================================
- Hits          7253     7250       -3     
- Misses         274      277       +3     
  Partials         2        2
Impacted Files Coverage Δ
components/_util/wave.tsx 85.57% <0%> (-2.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19fc777...515a4d6. Read the comment docs.

@chenshuai2144 chenshuai2144 merged commit b133c4a into feature Aug 16, 2019

27 of 29 checks passed

Build
Details
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 214 new files uploaded
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
License Compliance All checks passed.
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No significant change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 19fc777...515a4d6
Details
codecov/project 96.29% (-0.04%) compared to 19fc777
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@chenshuai2144 chenshuai2144 deleted the descript-style branch Aug 16, 2019

@chenshuai2144 chenshuai2144 referenced this pull request Aug 17, 2019
5 of 14 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.