Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: descriptions style update #18270

Merged
merged 5 commits into from Aug 16, 2019
Merged

style: descriptions style update #18270

merged 5 commits into from Aug 16, 2019

Conversation

chenshuai2144
Copy link
Contributor

@chenshuai2144 chenshuai2144 commented Aug 14, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

descriptions 非 border 模式下 的 padding 不会跟着 size 走。在 pageheader 中 16 有点大。但是不能用 border 模式。这个 pr 修复了这个问题

📝 Changelog

Language Changelog
🇺🇸 English The size of Descriptions now controls the padding-bottom of Descriptions.Item
🇨🇳 Chinese Descriptions 的 size 现在会控制 Descriptions.Item 的 padding-bottom

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/steps/demo/nav.md
View rendered components/steps/demo/simple.md
View rendered components/steps/index.en-US.md
View rendered components/steps/index.zh-CN.md
View rendered docs/react/i18n.en-US.md
View rendered docs/react/i18n.zh-CN.md

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@netlify
Copy link

netlify bot commented Aug 14, 2019

Deploy preview for ant-design ready!

Built with commit 515a4d6

https://deploy-preview-18270--ant-design.netlify.com

@chenshuai2144 chenshuai2144 changed the base branch from master to feature August 14, 2019 10:37
@afc163
Copy link
Member

afc163 commented Aug 14, 2019

Descriptions的 size 将会控制 item 的 padding-bottom

这个 changelog 有点看不懂。

💡 Background and solution

写一下解决什么问题。

@zombieJ
Copy link
Member

zombieJ commented Aug 15, 2019

没看出来和 https://ant.design/components/descriptions-cn/#components-descriptions-demo-size 的变化,加个 demo?

@codecov
Copy link

codecov bot commented Aug 15, 2019

Codecov Report

Merging #18270 into feature will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #18270      +/-   ##
===========================================
- Coverage    96.33%   96.29%   -0.04%     
===========================================
  Files          278      278              
  Lines         7529     7529              
  Branches      2077     2091      +14     
===========================================
- Hits          7253     7250       -3     
- Misses         274      277       +3     
  Partials         2        2
Impacted Files Coverage Δ
components/_util/wave.tsx 85.57% <0%> (-2.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19fc777...515a4d6. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Aug 15, 2019

Codecov Report

Merging #18270 into feature will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #18270      +/-   ##
===========================================
- Coverage    96.33%   96.29%   -0.04%     
===========================================
  Files          278      278              
  Lines         7529     7529              
  Branches      2077     2091      +14     
===========================================
- Hits          7253     7250       -3     
- Misses         274      277       +3     
  Partials         2        2
Impacted Files Coverage Δ
components/_util/wave.tsx 85.57% <0%> (-2.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19fc777...515a4d6. Read the comment docs.

@thisrabbit
Copy link
Contributor

thisrabbit commented Oct 3, 2019

hello, 关于该更新, antd的文档 https://ant-design.gitee.io/components/descriptions-cn/#Descriptions 中 size 一项的说明还没有更新, 仍为

设置列表的大小。可以设置为 middle 、small, 或不填(只有设置 bordered={true} 生效)

应该去掉后面括号的内容

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants