Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allows to override the autocomplete prop in Cascader #18279

Merged
merged 1 commit into from Aug 15, 2019

Conversation

@zomars
Copy link
Contributor

commented Aug 14, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

Regarding my comment on this issue. This will allow me to fix Chrome's autofill bug.

馃挕 Background and solution

馃摑 Changelog

No breaking changes, just let's me override the Cascader autocomplete prop.

Language Changelog
馃嚭馃嚫 English
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
[FIX] Allos to override the autocomplete prop in Cascader
Regarding [my comment on this issue](#15875 (comment)). This will allow me to fix [Chrome's autofill bug](https://bugs.chromium.org/p/chromium/issues/detail?id=370363#c7).

@pr-triage pr-triage bot added the PR: unreviewed label Aug 14, 2019

@netlify

This comment has been minimized.

Copy link

commented Aug 14, 2019

Deploy preview for ant-design ready!

Built with commit 76a30f0

https://deploy-preview-18279--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Aug 15, 2019

Codecov Report

Merging #18279 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18279      +/-   ##
==========================================
+ Coverage   96.29%   96.29%   +<.01%     
==========================================
  Files         276      276              
  Lines        7527     7528       +1     
  Branches     2088     2089       +1     
==========================================
+ Hits         7248     7249       +1     
  Misses        277      277              
  Partials        2        2
Impacted Files Coverage 螖
components/cascader/index.tsx 97.08% <100%> (+0.01%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update a223f6d...76a30f0. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

commented Aug 15, 2019

Codecov Report

Merging #18279 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18279      +/-   ##
==========================================
+ Coverage   96.29%   96.29%   +<.01%     
==========================================
  Files         276      276              
  Lines        7527     7528       +1     
  Branches     2088     2089       +1     
==========================================
+ Hits         7248     7249       +1     
  Misses        277      277              
  Partials        2        2
Impacted Files Coverage 螖
components/cascader/index.tsx 97.08% <100%> (+0.01%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update a223f6d...76a30f0. Read the comment docs.

@afc163 afc163 changed the title [FIX] Allows to override the autocomplete prop in Cascader fix: Allows to override the autocomplete prop in Cascader Aug 15, 2019

@afc163 afc163 merged commit bf3763e into ant-design:master Aug 15, 2019

26 of 28 checks passed

Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 214 new files uploaded
Details
DEP All dependencies are resolved
LGTM analysis: JavaScript No new or fixed alerts
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 96.29%)
Details
codecov/project 96.29% (+<.01%) compared to a223f6d
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Aug 15, 2019

@zomars zomars deleted the zomars:patch-1 branch Aug 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.