Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ts compile error with import React fix-ts-1259 #18282

Merged
merged 3 commits into from Aug 15, 2019
Merged

fix: ts compile error with import React fix-ts-1259 #18282

merged 3 commits into from Aug 15, 2019

Conversation

lidianhao123
Copy link

@lidianhao123 lidianhao123 commented Aug 15, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#18273 #18259

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English fix typescript compile error width import React from 'react'
🇨🇳 Chinese 修复 React 的引用方式变化造成的错误

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Aug 15, 2019

Deploy preview for ant-design ready!

Built with commit dd7e0c5

https://deploy-preview-18282--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Aug 15, 2019

Codecov Report

Merging #18282 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18282   +/-   ##
=======================================
  Coverage   96.29%   96.29%           
=======================================
  Files         276      276           
  Lines        7527     7527           
  Branches     2088     2077   -11     
=======================================
  Hits         7248     7248           
  Misses        277      277           
  Partials        2        2
Impacted Files Coverage Δ
components/badge/ScrollNumber.tsx 98.7% <100%> (ø) ⬆️
components/breadcrumb/Breadcrumb.tsx 96.66% <100%> (ø) ⬆️
components/tooltip/index.tsx 96.62% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a223f6d...dd7e0c5. Read the comment docs.

components/breadcrumb/Breadcrumb.tsx Outdated Show resolved Hide resolved
@afc163 afc163 merged commit 2c63305 into ant-design:master Aug 15, 2019
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants