Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:progress): fix progress styles to adapt changes in rc progress #18284

Merged
merged 1 commit into from Aug 16, 2019

Conversation

@wendzhue
Copy link
Contributor

commented Aug 15, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#18113

💡 Background and solution

I fixed the issue above partialy in rc-progress. You can find the pull request here.

However, we need to changes styles files to adapt those changes.

📝 Changelog

Language Changelog
🇺🇸 English fix gradient and successPercent cannot be used at the same time, fix stroke falls back to the previous one's stroke
🇨🇳 Chinese 修复不能同时使用渐变和 successPercent,以及渐变错误时采用前一个组件的渐变的问题

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label Aug 15, 2019

@netlify

This comment has been minimized.

Copy link

commented Aug 15, 2019

Deploy preview for ant-design ready!

Built with commit 2eb3d22

https://deploy-preview-18284--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Aug 15, 2019

Codecov Report

Merging #18284 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18284   +/-   ##
=======================================
  Coverage   96.29%   96.29%           
=======================================
  Files         276      276           
  Lines        7527     7527           
  Branches     2088     2047   -41     
=======================================
  Hits         7248     7248           
  Misses        277      277           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a223f6d...2eb3d22. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

commented Aug 15, 2019

Codecov Report

Merging #18284 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18284   +/-   ##
=======================================
  Coverage   96.29%   96.29%           
=======================================
  Files         276      276           
  Lines        7527     7527           
  Branches     2088     2047   -41     
=======================================
  Hits         7248     7248           
  Misses        277      277           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a223f6d...2eb3d22. Read the comment docs.

@wendzhue

This comment has been minimized.

Copy link
Contributor Author

commented Aug 16, 2019

Ping @zombieJ

@afc163 afc163 merged commit 3b0723b into ant-design:master Aug 16, 2019

25 of 28 checks passed

Header rules - ant-design No header rules processed
Details
LGTM analysis: JavaScript No code changes detected
Details
Pages changed - ant-design 215 new files uploaded
Details
DEP All dependencies are resolved
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing a223f6d...2eb3d22
Details
codecov/project 96.29% remains the same compared to a223f6d
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Aug 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.