Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ResizeObserver should ignore shaking #18289

Merged
merged 3 commits into from Aug 15, 2019
Merged

fix: ResizeObserver should ignore shaking #18289

merged 3 commits into from Aug 15, 2019

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Aug 15, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #18216

💡 Background and solution

Measure fixed value before ResizeObserver trigger onResize

📝 Changelog

Language Changelog
🇺🇸 English Fix TextArea autoresize with maxRows cause scrollbar blink.
🇨🇳 Chinese 修复 TextArea autoresize 使用 maxRows 时滚动条出现闪烁的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@netlify
Copy link

netlify bot commented Aug 15, 2019

Deploy preview for ant-design ready!

Built with commit daa70d3

https://deploy-preview-18289--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Aug 15, 2019

Codecov Report

Merging #18289 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18289      +/-   ##
==========================================
+ Coverage   96.29%   96.33%   +0.04%     
==========================================
  Files         276      276              
  Lines        7528     7535       +7     
  Branches     2048     2079      +31     
==========================================
+ Hits         7249     7259      +10     
+ Misses        277      274       -3     
  Partials        2        2
Impacted Files Coverage Δ
components/_util/resizeObserver.tsx 100% <100%> (ø) ⬆️
components/_util/wave.tsx 88.46% <0%> (+2.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c63305...daa70d3. Read the comment docs.

@zombieJ zombieJ merged commit fd284ec into master Aug 15, 2019
22 checks passed
@zombieJ zombieJ deleted the resize-fix branch Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TextArea props autosize={{ minRows: 2, maxRows: 6 }} scrollbar blinking
1 participant