Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: submenu popupClassName and className chaos #18290

Merged
merged 3 commits into from Aug 17, 2019

Conversation

@jljsj33
Copy link
Member

commented Aug 15, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese className 与 popupClassName 混乱,

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

className 应该是 item li 的样式,不应该带到 popupMenu 上

@pr-triage pr-triage bot added the PR: unreviewed label Aug 15, 2019

@netlify

This comment has been minimized.

Copy link

commented Aug 15, 2019

Deploy preview for ant-design ready!

Built with commit 62f6744

https://deploy-preview-18290--ant-design.netlify.com

@jljsj33 jljsj33 requested a review from zombieJ Aug 15, 2019

jljsj33 added 2 commits Aug 15, 2019
@codecov

This comment has been minimized.

Copy link

commented Aug 15, 2019

Codecov Report

Merging #18290 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18290      +/-   ##
==========================================
- Coverage   96.33%   96.29%   -0.04%     
==========================================
  Files         276      276              
  Lines        7523     7523              
  Branches     2088     2088              
==========================================
- Hits         7247     7244       -3     
- Misses        274      277       +3     
  Partials        2        2
Impacted Files Coverage Δ
components/menu/SubMenu.tsx 90% <100%> (ø) ⬆️
components/_util/wave.tsx 85.57% <0%> (-2.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab9d858...62f6744. Read the comment docs.

@jljsj33 jljsj33 requested a review from yesmeck Aug 15, 2019

@jljsj33

This comment has been minimized.

Copy link
Member Author

commented Aug 15, 2019

@yesmeck 解释下这个 popupClassName 为什么去合 className ?

@jljsj33 jljsj33 changed the title fix: submenu popupClassName and className chaos [WIP]fix: submenu popupClassName and className chaos Aug 15, 2019

@pr-triage pr-triage bot removed the PR: unreviewed label Aug 15, 2019

@jljsj33

This comment has been minimized.

Copy link
Member Author

commented Aug 15, 2019

这鬼东西还有个 bug ,,,props 更改 className 后,active 样式消失,

@jljsj33 jljsj33 changed the title [WIP]fix: submenu popupClassName and className chaos fix: submenu popupClassName and className chaos Aug 16, 2019

@pr-triage pr-triage bot added the PR: unreviewed label Aug 16, 2019

@jljsj33

This comment has been minimized.

Copy link
Member Author

commented Aug 16, 2019

有没有反应的啊,,谁埋的坑,出来冒个泡。。。

@yesmeck

This comment has been minimized.

Copy link
Member

commented Aug 16, 2019

就是当时写错了吧

@afc163
Copy link
Member

left a comment

给个问题重现

@afc163 afc163 merged commit ced96b9 into master Aug 17, 2019

28 of 30 checks passed

Build
Details
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 214 new files uploaded
Details
DEP All dependencies are resolved
LGTM analysis: JavaScript No new or fixed alerts
Details
License Compliance All checks passed.
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 96.33%)
Details
codecov/project Absolute coverage decreased by -0.03% but relative coverage increased by +3.66% compared to ab9d858
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@afc163 afc163 deleted the jljsj33-patch-1 branch Aug 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.