Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade rc-mentions #18298

Merged
merged 3 commits into from Aug 17, 2019

Conversation

@vijayst
Copy link
Contributor

commented Aug 15, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

react-component/mentions#9

馃挕 Background and solution

The new Mentions component does not have getPopupContainer prop. Added it to rc-mentions. Now upgrading the rc-mentions reference to 0.4 to take advantage of the new prop.

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English Upgrade rc-mentions
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label Aug 15, 2019

@netlify

This comment has been minimized.

Copy link

commented Aug 15, 2019

Deploy preview for ant-design ready!

Built with commit 9983b6c

https://deploy-preview-18298--ant-design.netlify.com

@vijayst

This comment has been minimized.

Copy link
Contributor Author

commented Aug 15, 2019

@zombieJ - closed the previous PR and added a new PR to feature branch

@zombieJ

This comment has been minimized.

Copy link
Member

commented Aug 15, 2019

@vijayst, docs update also : )

@codecov

This comment has been minimized.

Copy link

commented Aug 15, 2019

Codecov Report

Merging #18298 into feature will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #18298      +/-   ##
===========================================
- Coverage    96.33%   96.29%   -0.04%     
===========================================
  Files          278      278              
  Lines         7529     7529              
  Branches      2077     2047      -30     
===========================================
- Hits          7253     7250       -3     
- Misses         274      277       +3     
  Partials         2        2
Impacted Files Coverage 螖
components/_util/wave.tsx 85.57% <0%> (-2.89%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 19fc777...9983b6c. Read the comment docs.

@vijayst vijayst changed the title upgrade rc-mentions feat: upgrade rc-mentions Aug 16, 2019

@buildsize

This comment has been minimized.

Copy link

commented Aug 16, 2019

File name Previous Size New Size Change
package-lock.json 829.65聽KB 832.47聽KB 2.82聽KB (0%)
@afc163
afc163 approved these changes Aug 17, 2019

@afc163 afc163 merged commit c7e11a0 into ant-design:feature Aug 17, 2019

23 of 26 checks passed

ci/circleci: lint Your tests failed on CircleCI
Details
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 216 new files uploaded
Details
DEP All dependencies are resolved
LGTM analysis: JavaScript No new or fixed alerts
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize Significant change of package-lock.json up by 2.82聽KB (0.34%)
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.