Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add style to CheckableTagProps #18300

Merged
merged 1 commit into from Aug 15, 2019

Conversation

escapiststupor
Copy link
Contributor

@escapiststupor escapiststupor commented Aug 15, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

#18299

馃挕 Background and solution

Since you are spreading the restProps (here)[https://github.com/ant-design/ant-design/blob/master/components/tag/CheckableTag.tsx#L33] we should add style?: React.CSSProperties to CheckableTagProps so we can pass in a style object.

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English add style?: React.CSSProperties to CheckableTagProps
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Aug 15, 2019

Deploy preview for ant-design ready!

Built with commit dd82192

https://deploy-preview-18300--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Aug 15, 2019

Codecov Report

Merging #18300 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18300      +/-   ##
==========================================
+ Coverage   96.29%   96.33%   +0.03%     
==========================================
  Files         276      276              
  Lines        7530     7530              
  Branches     2092     2048      -44     
==========================================
+ Hits         7251     7254       +3     
+ Misses        277      274       -3     
  Partials        2        2
Impacted Files Coverage 螖
components/tag/CheckableTag.tsx 75% <酶> (酶) 猬嗭笍
components/_util/wave.tsx 88.46% <0%> (+2.88%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update fd284ec...dd82192. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Aug 15, 2019

Codecov Report

Merging #18300 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18300      +/-   ##
==========================================
+ Coverage   96.29%   96.33%   +0.03%     
==========================================
  Files         276      276              
  Lines        7530     7530              
  Branches     2092     2048      -44     
==========================================
+ Hits         7251     7254       +3     
+ Misses        277      274       -3     
  Partials        2        2
Impacted Files Coverage 螖
components/tag/CheckableTag.tsx 75% <酶> (酶) 猬嗭笍
components/_util/wave.tsx 88.46% <0%> (+2.88%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update fd284ec...dd82192. Read the comment docs.

@escapiststupor escapiststupor changed the title add style to CheckableTagProps fix: add style to CheckableTagProps Aug 15, 2019
@zombieJ zombieJ merged commit ea6bf51 into ant-design:master Aug 15, 2019
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants