Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cascader notFoundContent width #18325

Merged
merged 2 commits into from Aug 17, 2019

Conversation

@afc163
Copy link
Member

commented Aug 17, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #18176

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Cascader has wrong notFoundContent width when using fieldNames.
🇨🇳 Chinese 修复 Cascader 指定 fieldNames 是空数据弹层宽度问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label Aug 17, 2019

@tests-checker
Copy link

left a comment

Could you please add tests to make sure this change works as expected?

@netlify

This comment has been minimized.

Copy link

commented Aug 17, 2019

Deploy preview for ant-design ready!

Built with commit e660582

https://deploy-preview-18325--ant-design.netlify.com

@buildsize

This comment has been minimized.

Copy link

commented Aug 17, 2019

File name Previous Size New Size Change
package-lock.json 832.66 KB 831.68 KB -1002 bytes (0%)

@afc163 afc163 merged commit 4e9c477 into master Aug 17, 2019

13 of 25 checks passed

Build
Details
ant-design.ant-design in progress
Details
ci/circleci: dist CircleCI is running your tests
Details
ci/circleci: lint CircleCI is running your tests
Details
ci/circleci: test_dom CircleCI is running your tests
Details
ci/circleci: test_dom_15 CircleCI is running your tests
Details
ci/circleci: test_es Your tests are queued behind your running builds
Details
ci/circleci: test_es_15 Your tests are queued behind your running builds
Details
ci/circleci: test_lib Your tests are queued behind your running builds
Details
ci/circleci: test_lib_15 Your tests are queued behind your running builds
Details
netlify/ant-design/deploy-preview Deploy preview processing.
Details
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 214 new files uploaded
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
License Compliance All checks passed.
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
buildsize Significant change of package-lock.json down by 1002 bytes (0.12%)
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
security/snyk - package.json (paranoidjk) No new issues
Details

@afc163 afc163 deleted the fix-cascader-empty branch Aug 17, 2019

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Aug 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.