Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prop style is getting duplicated on Table (#18315) #18330

Merged
merged 1 commit into from Aug 19, 2019

Conversation

@MrHeer
Copy link
Contributor

commented Aug 18, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #18315

💡 Background and solution

#18315 (comment)

📝 Changelog

Language Changelog
🇺🇸 English fix: Prop style is getting duplicated on Table
🇨🇳 Chinese 修复: Table的sytle属性被应用了两次

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label Aug 18, 2019

@netlify

This comment has been minimized.

Copy link

commented Aug 18, 2019

Deploy preview for ant-design ready!

Built with commit d698333

https://deploy-preview-18330--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Aug 18, 2019

Codecov Report

Merging #18330 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18330   +/-   ##
=======================================
  Coverage   96.22%   96.22%           
=======================================
  Files         280      280           
  Lines        7527     7527           
  Branches     2052     2052           
=======================================
  Hits         7243     7243           
  Misses        282      282           
  Partials        2        2
Impacted Files Coverage Δ
components/table/Table.tsx 93.79% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b73ac96...d698333. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

commented Aug 18, 2019

Codecov Report

Merging #18330 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18330   +/-   ##
=======================================
  Coverage   96.22%   96.22%           
=======================================
  Files         280      280           
  Lines        7527     7527           
  Branches     2052     2052           
=======================================
  Hits         7243     7243           
  Misses        282      282           
  Partials        2        2
Impacted Files Coverage Δ
components/table/Table.tsx 93.79% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b73ac96...d698333. Read the comment docs.

@afc163 afc163 merged commit af39b46 into ant-design:master Aug 19, 2019

25 of 28 checks passed

DEP Checking dependencies
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 214 new files uploaded
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing b73ac96...d698333
Details
codecov/project 96.22% remains the same compared to b73ac96
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Aug 19, 2019

@MrHeer MrHeer deleted the MrHeer:fix-#18315 branch Aug 19, 2019

This was referenced Aug 25, 2019
@MrHeer MrHeer referenced this pull request Aug 27, 2019
1 of 1 task complete
@paranoidjk paranoidjk referenced this pull request Aug 27, 2019
1 of 14 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.