Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Anchor.Link add add new property target #18335

Merged
merged 2 commits into from Aug 19, 2019

Conversation

@DiamondYuan
Copy link
Collaborator

commented Aug 18, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #18310

📝 Changelog

Language Changelog
🇺🇸 English Anchor.Link add add new property target
🇨🇳 Chinese Anchor.Link 增加 target 属性

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/anchor/demo/basic.md

@pr-triage pr-triage bot added the PR: unreviewed label Aug 18, 2019

@netlify

This comment has been minimized.

Copy link

commented Aug 18, 2019

Deploy preview for ant-design ready!

Built with commit ab8e0d4

https://deploy-preview-18335--ant-design.netlify.com

@DiamondYuan

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 18, 2019

@DiamondYuan DiamondYuan requested a review from afc163 Aug 18, 2019

@codecov

This comment has been minimized.

Copy link

commented Aug 18, 2019

Codecov Report

Merging #18335 into feature will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #18335      +/-   ##
===========================================
+ Coverage    96.22%   96.26%   +0.03%     
===========================================
  Files          280      280              
  Lines         7527     7527              
  Branches      2052     2052              
===========================================
+ Hits          7243     7246       +3     
+ Misses         282      279       -3     
  Partials         2        2
Impacted Files Coverage Δ
components/anchor/AnchorLink.tsx 100% <100%> (ø) ⬆️
components/_util/wave.tsx 88.46% <0%> (+2.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8345554...ab8e0d4. Read the comment docs.

@afc163

This comment has been minimized.

Copy link
Member

commented Aug 18, 2019

feature branch

@DiamondYuan DiamondYuan changed the base branch from master to feature Aug 18, 2019

@DiamondYuan DiamondYuan force-pushed the fix/anchor-lint-target branch from 4852cd4 to 75879fe Aug 18, 2019

@buildsize

This comment has been minimized.

Copy link

commented Aug 18, 2019

File name Previous Size New Size Change
package-lock.json 832.71 KB 831.1 KB -1.62 KB (0%)
@DiamondYuan

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 18, 2019

feature branch

OK 👌

@hp2oo1

This comment has been minimized.

Copy link

commented Aug 18, 2019

It is a very helpful feature. When will it be released? Cannot wait to use it!

@DiamondYuan DiamondYuan force-pushed the fix/anchor-lint-target branch from 75879fe to ab8e0d4 Aug 19, 2019

@afc163
afc163 approved these changes Aug 19, 2019

@afc163 afc163 merged commit a5f1fc8 into feature Aug 19, 2019

27 of 29 checks passed

Build
Details
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 216 new files uploaded
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
License Compliance All checks passed.
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize Significant change of package-lock.json down by 1.62 KB (0.19%)
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 96.22%)
Details
codecov/project 96.26% (+0.03%) compared to 8345554
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@afc163 afc163 deleted the fix/anchor-lint-target branch Aug 19, 2019

@chenshuai2144 chenshuai2144 referenced this pull request Aug 25, 2019
5 of 14 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.