Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Anchor.Link add add new property target #18335

Merged
merged 2 commits into from Aug 19, 2019
Merged

Conversation

DiamondYuan
Copy link
Contributor

@DiamondYuan DiamondYuan commented Aug 18, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #18310

📝 Changelog

Language Changelog
🇺🇸 English Anchor.Link add add new property target
🇨🇳 Chinese Anchor.Link 增加 target 属性

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/anchor/demo/basic.md

@netlify
Copy link

netlify bot commented Aug 18, 2019

Deploy preview for ant-design ready!

Built with commit ab8e0d4

https://deploy-preview-18335--ant-design.netlify.com

@DiamondYuan
Copy link
Contributor Author

DiamondYuan commented Aug 18, 2019

Description of Property is from MDN https://developer.mozilla.org/zh-CN/docs/Web/HTML/Element/a

@DiamondYuan DiamondYuan requested a review from afc163 Aug 18, 2019
@codecov
Copy link

codecov bot commented Aug 18, 2019

Codecov Report

Merging #18335 into feature will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #18335      +/-   ##
===========================================
+ Coverage    96.22%   96.26%   +0.03%     
===========================================
  Files          280      280              
  Lines         7527     7527              
  Branches      2052     2052              
===========================================
+ Hits          7243     7246       +3     
+ Misses         282      279       -3     
  Partials         2        2
Impacted Files Coverage Δ
components/anchor/AnchorLink.tsx 100% <100%> (ø) ⬆️
components/_util/wave.tsx 88.46% <0%> (+2.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8345554...ab8e0d4. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Aug 18, 2019

feature branch

@DiamondYuan DiamondYuan changed the base branch from master to feature Aug 18, 2019
@buildsize
Copy link

buildsize bot commented Aug 18, 2019

File name Previous Size New Size Change
package-lock.json 832.71 KB 831.1 KB -1.62 KB (0%)

@DiamondYuan
Copy link
Contributor Author

DiamondYuan commented Aug 18, 2019

feature branch

OK 👌

afc163
afc163 previously approved these changes Aug 18, 2019
@hp2oo1
Copy link

hp2oo1 commented Aug 18, 2019

It is a very helpful feature. When will it be released? Cannot wait to use it!

components/anchor/index.en-US.md Outdated Show resolved Hide resolved
afc163
afc163 approved these changes Aug 19, 2019
@afc163 afc163 merged commit a5f1fc8 into feature Aug 19, 2019
22 checks passed
@afc163 afc163 deleted the fix/anchor-lint-target branch Aug 19, 2019
@chenshuai2144 chenshuai2144 mentioned this pull request Aug 25, 2019
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants