Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upgrade rc-input-number #18346

Merged
merged 1 commit into from Aug 19, 2019

Conversation

@afc163
Copy link
Member

commented Aug 19, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#9792
close #12476
close #16080

💡 Background and solution

Upgrade rc-input-number to 4.5.0: react-component/input-number#194

  • InputNumber 新增 onPressEnter 属性。
  • 修复 InputNumber 在 React 16.9 下的生命周期警告信息。

📝 Changelog

Language Changelog
🇺🇸 English - InputNumber support onPressEnter。
- Fix InputNumber React lifecycle warning.
🇨🇳 Chinese - InputNumber 新增 onPressEnter 属性。
- 修复 InputNumber 在 React 16.9 下的生命周期警告信息

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/input-number/index.en-US.md
View rendered components/input-number/index.zh-CN.md

🆙 Upgrade rc-input-number
* fix react warning #9792

* support onPressEnter
close #12476
close #16080

@pr-triage pr-triage bot added the PR: unreviewed label Aug 19, 2019

@netlify

This comment has been minimized.

Copy link

commented Aug 19, 2019

Deploy preview for ant-design ready!

Built with commit af6243e

https://deploy-preview-18346--ant-design.netlify.com

@afc163 afc163 merged commit c9cef60 into feature Aug 19, 2019

26 of 28 checks passed

Build
Details
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 214 new files uploaded
Details
DEP All dependencies are resolved
LGTM analysis: JavaScript No new or fixed alerts
Details
License Compliance All checks passed.
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No prior size to compare - 831.05 KB
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No new issues
Details

@afc163 afc163 deleted the upgrade-input-number branch Aug 19, 2019

@afc163 afc163 referenced this pull request Sep 2, 2019
5 of 14 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.