Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Steps vertical progressDot style #18356

Merged
merged 1 commit into from Aug 20, 2019

Conversation

@afc163
Copy link
Member

commented Aug 20, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #18354

💡 Background and solution

broken via #17994

image

After fix:

image

📝 Changelog

Language Changelog
🇺🇸 English Fix Steps progressDot broken style.
🇨🇳 Chinese 修复 Steps progressDot 样式错位问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/steps/demo/progress-dot.md

@pr-triage pr-triage bot added the PR: unreviewed label Aug 20, 2019

@netlify

This comment has been minimized.

Copy link

commented Aug 20, 2019

Deploy preview for ant-design ready!

Built with commit 9985cd0

https://deploy-preview-18356--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Aug 20, 2019

Codecov Report

Merging #18356 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18356   +/-   ##
=======================================
  Coverage   96.22%   96.22%           
=======================================
  Files         280      280           
  Lines        7527     7527           
  Branches     2094     2052   -42     
=======================================
  Hits         7243     7243           
  Misses        282      282           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3518f56...9985cd0. Read the comment docs.

@afc163 afc163 merged commit 14308db into master Aug 20, 2019

28 of 31 checks passed

Build
Details
Header rules - ant-design No header rules processed
Details
LGTM analysis: JavaScript No code changes detected
Details
Pages changed - ant-design 214 new files uploaded
Details
DEP All dependencies are resolved
License Compliance All checks passed.
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 3518f56...9985cd0
Details
codecov/project 96.22% remains the same compared to 3518f56
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@afc163 afc163 deleted the fix-steps branch Aug 20, 2019

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Aug 20, 2019

@afc163 afc163 referenced this pull request Aug 21, 2019
5 of 14 tasks complete
lewis617 pushed a commit to lewis617/ant-design that referenced this pull request Aug 22, 2019
This was referenced Aug 25, 2019
@MrHeer MrHeer referenced this pull request Aug 27, 2019
1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.