Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Not shaking with autosize of TextArea #18401

Merged
merged 6 commits into from Aug 22, 2019
Merged

fix: Not shaking with autosize of TextArea #18401

merged 6 commits into from Aug 22, 2019

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Aug 22, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #18366

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix TextArea with autosize in controlled mode that scrollbar blink when typing.
🇨🇳 Chinese 修复 TextArea 受控模式下配置 autosize 时,输入会导致滚动条闪烁的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/input/demo/autosize-textarea.md

@zombieJ zombieJ requested a review from afc163 Aug 22, 2019
@netlify
Copy link

netlify bot commented Aug 22, 2019

Deploy preview for ant-design ready!

Built with commit 20e6e48

https://deploy-preview-18401--ant-design.netlify.com

@zombieJ
Copy link
Member Author

zombieJ commented Aug 22, 2019

Add controlled example in the Demo. Please help to check. @afc163

@buildsize
Copy link

buildsize bot commented Aug 22, 2019

File name Previous Size New Size Change
package-lock.json 836.23 KB 832.68 KB -3.55 KB (0%)

@zombieJ zombieJ merged commit b9b9675 into master Aug 22, 2019
20 checks passed
@zombieJ zombieJ deleted the autosize branch Aug 22, 2019
@afc163
Copy link
Member

afc163 commented Aug 22, 2019

👍

@codecov
Copy link

codecov bot commented Aug 22, 2019

Codecov Report

Merging #18401 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18401      +/-   ##
==========================================
+ Coverage   96.22%   96.26%   +0.04%     
==========================================
  Files         280      276       -4     
  Lines        7527     7530       +3     
  Branches     2052     2078      +26     
==========================================
+ Hits         7243     7249       +6     
+ Misses        282      279       -3     
  Partials        2        2
Impacted Files Coverage Δ
components/input/TextArea.tsx 96.36% <100%> (-3.64%) ⬇️
components/anchor/Anchor.tsx 90.71% <0%> (-3.69%) ⬇️
components/table/Table.tsx 93.79% <0%> (ø) ⬆️
components/cascader/index.tsx 97.08% <0%> (ø) ⬆️
components/steps/index.tsx 100% <0%> (ø) ⬆️
components/modal/Modal.tsx 100% <0%> (ø) ⬆️
components/menu/SubMenu.tsx 90% <0%> (ø) ⬆️
components/time-picker/locale/ro_RO.tsx
components/_util/easings.ts
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7558273...20e6e48. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Aug 22, 2019

Codecov Report

Merging #18401 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18401      +/-   ##
==========================================
+ Coverage   96.22%   96.26%   +0.04%     
==========================================
  Files         280      276       -4     
  Lines        7527     7530       +3     
  Branches     2052     2078      +26     
==========================================
+ Hits         7243     7249       +6     
+ Misses        282      279       -3     
  Partials        2        2
Impacted Files Coverage Δ
components/input/TextArea.tsx 96.36% <100%> (-3.64%) ⬇️
components/anchor/Anchor.tsx 90.71% <0%> (-3.69%) ⬇️
components/table/Table.tsx 93.79% <0%> (ø) ⬆️
components/cascader/index.tsx 97.08% <0%> (ø) ⬆️
components/steps/index.tsx 100% <0%> (ø) ⬆️
components/modal/Modal.tsx 100% <0%> (ø) ⬆️
components/menu/SubMenu.tsx 90% <0%> (ø) ⬆️
components/time-picker/locale/ro_RO.tsx
components/_util/easings.ts
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7558273...20e6e48. Read the comment docs.

lewis617 pushed a commit to lewis617/ant-design that referenced this pull request Aug 22, 2019
* fix: Not shaking with autosize of TextArea

* fix ract 15 demo

* fix demo

* add state

* handle event

* try to fix react 15 test case
@chenshuai2144 chenshuai2144 mentioned this pull request Aug 26, 2019
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v3.22.0-TextArea 受控模式并使用maxRows,输入时滚动条闪烁
2 participants