Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upload newline bug #18423

Merged
merged 1 commit into from Aug 22, 2019

Conversation

@lihuanji
Copy link
Contributor

commented Aug 22, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

#16045

馃挕 Background and solution

  • fix before
    QQ20190822-200626-HD
  • fix after
    QQ20190822-201016-HD

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label Aug 22, 2019

@netlify

This comment has been minimized.

Copy link

commented Aug 22, 2019

Deploy preview for ant-design ready!

Built with commit 0de0609

https://deploy-preview-18423--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Aug 22, 2019

Codecov Report

Merging #18423 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18423      +/-   ##
==========================================
- Coverage   96.44%    96.4%   -0.04%     
==========================================
  Files         280      280              
  Lines        7514     7514              
  Branches     2047     2047              
==========================================
- Hits         7247     7244       -3     
- Misses        265      268       +3     
  Partials        2        2
Impacted Files Coverage 螖
components/_util/wave.tsx 85.57% <0%> (-2.89%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 371ba4d...0de0609. Read the comment docs.

@afc163

This comment has been minimized.

Copy link
Member

commented Aug 22, 2019

@afc163 afc163 changed the title fix upload newline bug fix: upload newline bug Aug 22, 2019

@afc163 afc163 merged commit 743ec29 into ant-design:master Aug 22, 2019

26 of 29 checks passed

Header rules - ant-design No header rules processed
Details
LGTM analysis: JavaScript No code changes detected
Details
Pages changed - ant-design 215 new files uploaded
Details
DEP All dependencies are resolved
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 371ba4d...0de0609
Details
codecov/project 96.4% (-0.04%) compared to 371ba4d
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Aug 22, 2019

@chenshuai2144 chenshuai2144 referenced this pull request Aug 26, 2019
1 of 10 tasks complete
@MrHeer MrHeer referenced this pull request Aug 27, 2019
1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.