Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add tabBarExtraContent property to Card component #18433

Merged
merged 1 commit into from Aug 23, 2019
Merged

feat: Add tabBarExtraContent property to Card component #18433

merged 1 commit into from Aug 23, 2019

Conversation

bytemain
Copy link
Member

@bytemain bytemain commented Aug 23, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close: #18370

💡 Background and solution

You can add a button after the tabs list.
image

📝 Changelog

Language Changelog
🇺🇸 English Add tabBarExtraContent property to Card component
🇨🇳 Chinese 为 Card 组件 新增了 tabBarExtraContent 的 property

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/card/demo/tabs.md
View rendered components/card/index.en-US.md
View rendered components/card/index.zh-CN.md

@netlify
Copy link

netlify bot commented Aug 23, 2019

Deploy preview for ant-design ready!

Built with commit 45eaa39

https://deploy-preview-18433--ant-design.netlify.com

@buildsize
Copy link

buildsize bot commented Aug 23, 2019

File name Previous Size New Size Change
package-lock.json 835.83 KB 833.01 KB -2.82 KB (0%)

@codecov
Copy link

codecov bot commented Aug 23, 2019

Codecov Report

Merging #18433 into feature will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #18433      +/-   ##
===========================================
+ Coverage    96.22%   96.26%   +0.03%     
===========================================
  Files          280      280              
  Lines         7533     7533              
  Branches      2098     2095       -3     
===========================================
+ Hits          7249     7252       +3     
+ Misses         282      279       -3     
  Partials         2        2
Impacted Files Coverage Δ
components/card/index.tsx 100% <ø> (ø) ⬆️
components/_util/wave.tsx 88.46% <0%> (+2.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9f6e8d...45eaa39. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Aug 23, 2019

Codecov Report

Merging #18433 into feature will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #18433      +/-   ##
===========================================
+ Coverage    96.22%   96.26%   +0.03%     
===========================================
  Files          280      280              
  Lines         7533     7533              
  Branches      2098     2095       -3     
===========================================
+ Hits          7249     7252       +3     
+ Misses         282      279       -3     
  Partials         2        2
Impacted Files Coverage Δ
components/card/index.tsx 100% <ø> (ø) ⬆️
components/_util/wave.tsx 88.46% <0%> (+2.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9f6e8d...45eaa39. Read the comment docs.

@afc163 afc163 changed the title Add tabBarExtraContent property to Card component feat: Add tabBarExtraContent property to Card component Aug 23, 2019
afc163
afc163 approved these changes Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants