Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add tabBarExtraContent property to Card component #18433

Merged
merged 1 commit into from Aug 23, 2019

Conversation

@lengthmin
Copy link
Contributor

commented Aug 23, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close: #18370

💡 Background and solution

You can add a button after the tabs list.
image

📝 Changelog

Language Changelog
🇺🇸 English Add tabBarExtraContent property to Card component
🇨🇳 Chinese 为 Card 组件 新增了 tabBarExtraContent 的 property

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/card/demo/tabs.md
View rendered components/card/index.en-US.md
View rendered components/card/index.zh-CN.md

@pr-triage pr-triage bot added the PR: unreviewed label Aug 23, 2019

@netlify

This comment has been minimized.

Copy link

commented Aug 23, 2019

Deploy preview for ant-design ready!

Built with commit 45eaa39

https://deploy-preview-18433--ant-design.netlify.com

@buildsize

This comment has been minimized.

Copy link

commented Aug 23, 2019

File name Previous Size New Size Change
package-lock.json 835.83 KB 833.01 KB -2.82 KB (0%)
@codecov

This comment has been minimized.

Copy link

commented Aug 23, 2019

Codecov Report

Merging #18433 into feature will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #18433      +/-   ##
===========================================
+ Coverage    96.22%   96.26%   +0.03%     
===========================================
  Files          280      280              
  Lines         7533     7533              
  Branches      2098     2095       -3     
===========================================
+ Hits          7249     7252       +3     
+ Misses         282      279       -3     
  Partials         2        2
Impacted Files Coverage Δ
components/card/index.tsx 100% <ø> (ø) ⬆️
components/_util/wave.tsx 88.46% <0%> (+2.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9f6e8d...45eaa39. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

commented Aug 23, 2019

Codecov Report

Merging #18433 into feature will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #18433      +/-   ##
===========================================
+ Coverage    96.22%   96.26%   +0.03%     
===========================================
  Files          280      280              
  Lines         7533     7533              
  Branches      2098     2095       -3     
===========================================
+ Hits          7249     7252       +3     
+ Misses         282      279       -3     
  Partials         2        2
Impacted Files Coverage Δ
components/card/index.tsx 100% <ø> (ø) ⬆️
components/_util/wave.tsx 88.46% <0%> (+2.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9f6e8d...45eaa39. Read the comment docs.

@afc163 afc163 changed the title Add tabBarExtraContent property to Card component feat: Add tabBarExtraContent property to Card component Aug 23, 2019

@afc163
afc163 approved these changes Aug 23, 2019

@afc163 afc163 merged commit 5e10d5a into ant-design:feature Aug 23, 2019

27 of 29 checks passed

Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 215 new files uploaded
Details
DEP All dependencies are resolved
LGTM analysis: JavaScript No new or fixed alerts
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize Significant change of package-lock.json down by 2.82 KB (0.34%)
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing f9f6e8d...45eaa39
Details
codecov/project 96.26% (+0.03%) compared to f9f6e8d
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
@chenshuai2144 chenshuai2144 referenced this pull request Aug 25, 2019
5 of 14 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.