Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: descriptions background is not themeable (#18372) #18440

Merged
merged 1 commit into from Aug 23, 2019

Conversation

@MrHeer
Copy link
Contributor

commented Aug 23, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #18372

💡 Background and solution

use @descriptions-bg instead #fafafa

📝 Changelog

Language Changelog
🇺🇸 English fix: descriptions background is not themeable
🇨🇳 Chinese 修复: Descriptions 背景色没有主题化

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label Aug 23, 2019

@afc163 afc163 merged commit 721a545 into ant-design:master Aug 23, 2019

4 of 7 checks passed

ant-design.ant-design in progress
Details
ci/circleci: setup CircleCI is running your tests
Details
LGTM analysis: JavaScript No code changes detected
Details
DEP All dependencies are resolved
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Aug 23, 2019

@MrHeer MrHeer deleted the MrHeer:fix-#18372 branch Aug 23, 2019

@netlify

This comment has been minimized.

Copy link

commented Aug 23, 2019

Deploy preview for ant-design ready!

Built with commit 1c6672a

https://deploy-preview-18440--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Aug 23, 2019

Codecov Report

Merging #18440 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18440   +/-   ##
=======================================
  Coverage    96.4%    96.4%           
=======================================
  Files         280      280           
  Lines        7514     7514           
  Branches     2047     2047           
=======================================
  Hits         7244     7244           
  Misses        268      268           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38b8d07...1c6672a. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

commented Aug 23, 2019

Codecov Report

Merging #18440 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18440   +/-   ##
=======================================
  Coverage    96.4%    96.4%           
=======================================
  Files         280      280           
  Lines        7514     7514           
  Branches     2047     2047           
=======================================
  Hits         7244     7244           
  Misses        268      268           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38b8d07...1c6672a. Read the comment docs.

@chenshuai2144 chenshuai2144 referenced this pull request Aug 26, 2019
1 of 10 tasks complete
@MrHeer MrHeer referenced this pull request Aug 27, 2019
1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.