Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Input.Password cannot get input element #18441

Merged
merged 1 commit into from Aug 23, 2019

Conversation

@afc163
Copy link
Member

commented Aug 23, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #18412

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese 修复 Input.Password ref 获取不到 input 元素且没有 focus blur 方法的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label Aug 23, 2019

@tests-checker
Copy link

left a comment

Could you please add tests to make sure this change works as expected?

@netlify

This comment has been minimized.

Copy link

commented Aug 23, 2019

Deploy preview for ant-design ready!

Built with commit 4249b42

https://deploy-preview-18441--ant-design.netlify.com

@afc163 afc163 changed the title :bug: Fix Input.Password cannot get input element fix: Input.Password cannot get input element Aug 23, 2019

@afc163 afc163 force-pushed the fix-input-password branch from 49ce33d to fb7fb89 Aug 23, 2019

@afc163 afc163 force-pushed the fix-input-password branch from fb7fb89 to 46bcd62 Aug 23, 2019

@codecov

This comment has been minimized.

Copy link

commented Aug 23, 2019

Codecov Report

Merging #18441 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18441      +/-   ##
==========================================
+ Coverage    96.4%   96.45%   +0.04%     
==========================================
  Files         280      280              
  Lines        7514     7522       +8     
  Branches     2089     2047      -42     
==========================================
+ Hits         7244     7255      +11     
+ Misses        268      265       -3     
  Partials        2        2
Impacted Files Coverage Δ
components/input/Password.tsx 100% <100%> (ø) ⬆️
components/_util/wave.tsx 88.46% <0%> (+2.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 021e9af...4249b42. Read the comment docs.

@afc163 afc163 force-pushed the fix-input-password branch from 46bcd62 to 4249b42 Aug 23, 2019

@afc163 afc163 merged commit c6c947f into master Aug 23, 2019

28 of 30 checks passed

Build
Details
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 214 new files uploaded
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
License Compliance All checks passed.
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 96.4%)
Details
codecov/project 96.45% (+0.04%) compared to 021e9af
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@afc163 afc163 deleted the fix-input-password branch Aug 23, 2019

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Aug 23, 2019

@chenshuai2144 chenshuai2144 referenced this pull request Aug 26, 2019
1 of 10 tasks complete
@hjiawei hjiawei referenced this pull request Aug 26, 2019
0 of 1 task complete
@amfoter

This comment has been minimized.

Copy link

commented Aug 26, 2019

Having the same issue. had to downgrade to 3.22.0 and wait for the next update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.