Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Input.Password cannot get input element #18441

Merged
merged 1 commit into from Aug 23, 2019
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Aug 23, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #18412

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese 修复 Input.Password ref 获取不到 input 元素且没有 focus blur 方法的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@netlify
Copy link

netlify bot commented Aug 23, 2019

Deploy preview for ant-design ready!

Built with commit 4249b42

https://deploy-preview-18441--ant-design.netlify.com

@afc163 afc163 changed the title 🐛 Fix Input.Password cannot get input element fix: Input.Password cannot get input element Aug 23, 2019
@codecov
Copy link

codecov bot commented Aug 23, 2019

Codecov Report

Merging #18441 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18441      +/-   ##
==========================================
+ Coverage    96.4%   96.45%   +0.04%     
==========================================
  Files         280      280              
  Lines        7514     7522       +8     
  Branches     2089     2047      -42     
==========================================
+ Hits         7244     7255      +11     
+ Misses        268      265       -3     
  Partials        2        2
Impacted Files Coverage Δ
components/input/Password.tsx 100% <100%> (ø) ⬆️
components/_util/wave.tsx 88.46% <0%> (+2.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 021e9af...4249b42. Read the comment docs.

@afc163 afc163 merged commit c6c947f into master Aug 23, 2019
23 checks passed
@afc163 afc163 deleted the fix-input-password branch Aug 23, 2019
@chenshuai2144 chenshuai2144 mentioned this pull request Aug 26, 2019
10 tasks
@amir-khademi
Copy link

amir-khademi commented Aug 26, 2019

Having the same issue. had to downgrade to 3.22.0 and wait for the next update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input.Password 组件 ref 无法获取到 input
2 participants