Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: less vars for select and anchor #18444

Merged
merged 1 commit into from Aug 23, 2019

Conversation

@ycjcl868
Copy link
Member

commented Aug 23, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

馃挕 Background and solution

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English 馃拕 Add variables @select-dropdown-bg @select-item-selected-bg @select-item-active-bg @anchor-border-color
馃嚚馃嚦 Chinese 馃拕澧炲姞 less 鍙橀噺 @select-dropdown-bg @select-item-selected-bg @select-item-active-bg @anchor-border-colorr

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label Aug 23, 2019

@netlify

This comment has been minimized.

Copy link

commented Aug 23, 2019

Deploy preview for ant-design ready!

Built with commit 2155084

https://deploy-preview-18444--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Aug 23, 2019

Codecov Report

Merging #18444 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18444      +/-   ##
==========================================
+ Coverage    96.4%   96.44%   +0.03%     
==========================================
  Files         280      280              
  Lines        7514     7514              
  Branches     2089     2089              
==========================================
+ Hits         7244     7247       +3     
+ Misses        268      265       -3     
  Partials        2        2
Impacted Files Coverage 螖
components/_util/wave.tsx 88.46% <0%> (+2.88%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 721a545...2155084. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

commented Aug 23, 2019

Codecov Report

Merging #18444 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18444      +/-   ##
==========================================
+ Coverage    96.4%   96.44%   +0.03%     
==========================================
  Files         280      280              
  Lines        7514     7514              
  Branches     2089     2089              
==========================================
+ Hits         7244     7247       +3     
+ Misses        268      265       -3     
  Partials        2        2
Impacted Files Coverage 螖
components/_util/wave.tsx 88.46% <0%> (+2.88%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 721a545...2155084. Read the comment docs.

@afc163 afc163 merged commit 021e9af into master Aug 23, 2019

28 of 31 checks passed

Build
Details
Header rules - ant-design No header rules processed
Details
LGTM analysis: JavaScript No code changes detected
Details
Pages changed - ant-design 214 new files uploaded
Details
DEP All dependencies are resolved
License Compliance All checks passed.
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 721a545...2155084
Details
codecov/project 96.44% (+0.03%) compared to 721a545
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@afc163 afc163 deleted the feat-less-vars branch Aug 23, 2019

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Aug 23, 2019

@chenshuai2144 chenshuai2144 referenced this pull request Aug 26, 2019
1 of 10 tasks complete
@MrHeer MrHeer referenced this pull request Aug 27, 2019
1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.