Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: result types #18445

Merged
merged 2 commits into from Sep 6, 2019

Conversation

@ycjcl868
Copy link
Member

commented Aug 23, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

馃挕 Background and solution

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label Aug 23, 2019

@netlify

This comment has been minimized.

Copy link

commented Aug 23, 2019

Deploy preview for ant-design ready!

Built with commit 77254c6

https://deploy-preview-18445--ant-design.netlify.com

@ycjcl868 ycjcl868 force-pushed the fix-result-types branch from cb1b867 to a346d49 Aug 25, 2019

@codecov

This comment has been minimized.

Copy link

commented Aug 25, 2019

Codecov Report

Merging #18445 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18445   +/-   ##
=======================================
  Coverage   96.41%   96.41%           
=======================================
  Files         280      280           
  Lines        7522     7522           
  Branches     2089     2089           
=======================================
  Hits         7252     7252           
  Misses        268      268           
  Partials        2        2
Impacted Files Coverage 螖
components/result/index.tsx 100% <100%> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 271c7aa...77254c6. Read the comment docs.

@ycjcl868

This comment has been minimized.

Copy link
Member Author

commented Aug 25, 2019

绫诲瀷鏈夌偣闂锛屽厛涓嶅悎

@ztplz
ztplz approved these changes Aug 26, 2019
@@ -24,7 +24,7 @@ export type ResultStatusType = ExceptionStatusType | keyof typeof IconMap;

export interface ResultProps {
icon?: React.ReactNode;
status: ResultStatusType;
status?: ResultStatusType;

This comment has been minimized.

Copy link
@ztplz

ztplz Aug 26, 2019

Collaborator

status? === ResultStatusType || undefined 鐪嬩簡涓涓 鍚庨潰status鐩存帴瑙f瀯鐨 鐢ㄥ埌鐨勫湴鏂硅鍔爊on-null assertion operator

This comment has been minimized.

Copy link
@ycjcl868

ycjcl868 Aug 27, 2019

Author Member

status 鍙互涓嶄紶锛屾垜鍔犱竴鎶 asset

@@ -46,7 +46,7 @@ const ExceptionStatus = Object.keys(ExceptionMap);
const renderIcon = (prefixCls: string, { status, icon }: ResultProps) => {
const className = classnames(`${prefixCls}-icon`);

if (ExceptionStatus.includes(status)) {
if (ExceptionStatus.includes(status as ResultStatusType)) {

This comment has been minimized.

Copy link
@ztplz

ztplz Aug 27, 2019

Collaborator

涓嶉渶瑕乤ssertion 鐩存帴闈炵┖灏辫浜

@afc163 afc163 merged commit 35aaf6b into master Sep 6, 2019

28 of 30 checks passed

Build
Details
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 214 new files uploaded
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
License Compliance All checks passed.
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No significant change
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 96.41%)
Details
codecov/project 96.41% (+0%) compared to 271c7aa
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No new issues
Details

@afc163 afc163 deleted the fix-result-types branch Sep 6, 2019

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Sep 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.