Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configurable heading font-weight less var #18456

Merged
merged 1 commit into from Aug 26, 2019

Conversation

@MrHeer
Copy link
Contributor

commented Aug 25, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #18442

💡 Background and solution

use @typography-title-font-weight instead 600

📝 Changelog

Language Changelog
🇺🇸 English feat: Configurable heading font-weight
🇨🇳 Chinese 新增: 可配置标题的 font-weight

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label Aug 25, 2019

@netlify

This comment has been minimized.

Copy link

commented Aug 25, 2019

Deploy preview for ant-design ready!

Built with commit 9c6f4b7

https://deploy-preview-18456--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Aug 25, 2019

Codecov Report

Merging #18456 into feature will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #18456   +/-   ##
========================================
  Coverage    96.22%   96.22%           
========================================
  Files          280      280           
  Lines         7533     7533           
  Branches      2053     2095   +42     
========================================
  Hits          7249     7249           
  Misses         282      282           
  Partials         2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b9853f...9c6f4b7. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

commented Aug 25, 2019

Codecov Report

Merging #18456 into feature will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #18456   +/-   ##
========================================
  Coverage    96.22%   96.22%           
========================================
  Files          280      280           
  Lines         7533     7533           
  Branches      2053     2095   +42     
========================================
  Hits          7249     7249           
  Misses         282      282           
  Partials         2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b9853f...9c6f4b7. Read the comment docs.

@afc163 afc163 changed the title feat: Configurable heading font-weight (#18442) feat: Configurable heading font-weight Aug 26, 2019

@afc163 afc163 changed the title feat: Configurable heading font-weight feat: configurable heading font-weight less var Aug 26, 2019

@afc163
afc163 approved these changes Aug 26, 2019

@afc163 afc163 merged commit 14f280f into ant-design:feature Aug 26, 2019

26 of 29 checks passed

Header rules - ant-design No header rules processed
Details
LGTM analysis: JavaScript No code changes detected
Details
Pages changed - ant-design 215 new files uploaded
Details
DEP All dependencies are resolved
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 2b9853f...9c6f4b7
Details
codecov/project 96.22% remains the same compared to 2b9853f
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@MrHeer MrHeer deleted the MrHeer:feat-#18442 branch Aug 26, 2019

@chenshuai2144 chenshuai2144 referenced this pull request Sep 2, 2019
5 of 14 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.