Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow disabling hover effect for Card.Grid #18457

Merged
merged 1 commit into from Aug 30, 2019

Conversation

MrHeer
Copy link
Contributor

@MrHeer MrHeer commented Aug 25, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

#18448

馃挕 Background and solution

<Card.Grid hoverable={false}/>

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English feat: allow disabling hover effect for Card.Grid
馃嚚馃嚦 Chinese 鏂板: 鍏佽绂佺敤 Card.Grid 娴姩鏁堟灉

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/card/demo/grid-card.md
View rendered components/card/index.en-US.md
View rendered components/card/index.zh-CN.md

@netlify
Copy link

netlify bot commented Aug 25, 2019

Deploy preview for ant-design ready!

Built with commit d007de6

https://deploy-preview-18457--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Aug 25, 2019

Codecov Report

Merging #18457 into feature will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #18457      +/-   ##
===========================================
- Coverage    96.23%   96.22%   -0.01%     
===========================================
  Files          280      280              
  Lines         7542     7533       -9     
  Branches      2056     2099      +43     
===========================================
- Hits          7258     7249       -9     
  Misses         282      282              
  Partials         2        2
Impacted Files Coverage 螖
components/card/Grid.tsx 100% <100%> (酶) 猬嗭笍
components/page-header/index.tsx 100% <0%> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update e737e50...d007de6. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Aug 25, 2019

Codecov Report

Merging #18457 into feature will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #18457      +/-   ##
===========================================
- Coverage    96.23%   96.22%   -0.01%     
===========================================
  Files          280      280              
  Lines         7542     7533       -9     
  Branches      2056     2099      +43     
===========================================
- Hits          7258     7249       -9     
  Misses         282      282              
  Partials         2        2
Impacted Files Coverage 螖
components/card/Grid.tsx 100% <100%> (酶) 猬嗭笍
components/page-header/index.tsx 100% <0%> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update e737e50...d007de6. Read the comment docs.

@MrHeer MrHeer changed the title feat: allow disabling hover effect for Card.Grid (#18448) feat: allow disabling hover effect for Card.Grid Aug 27, 2019
afc163
afc163 approved these changes Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants