Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Capitalize Text and PageHeader default locale strings #18471

Merged
merged 1 commit into from Aug 27, 2019

Conversation

@hjiawei
Copy link
Contributor

commented Aug 26, 2019

Most of the locale strings in the default locale are capitalized. This
changeset makes Text and PageHeader locale strings consistent with
others. Also, "Copied" implies successfully so changing "copy success"
to "Copied" should be sufficient IMHO.

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

馃挕 Background and solution

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
Capitalize Text and PageHeader default locale strings
Most of the locale strings in the default locale are capitalized. This
changeset makes `Text` and `PageHeader` locale strings consistent with
others. Also, "Copied" implies successfully so changing "copy success"
to "Copied" should be sufficient IMHO.

@pr-triage pr-triage bot added the PR: unreviewed label Aug 26, 2019

@netlify

This comment has been minimized.

Copy link

commented Aug 26, 2019

Deploy preview for ant-design ready!

Built with commit 8523470

https://deploy-preview-18471--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Aug 26, 2019

Codecov Report

Merging #18471 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18471      +/-   ##
==========================================
- Coverage   96.45%   96.41%   -0.04%     
==========================================
  Files         280      280              
  Lines        7522     7522              
  Branches     2089     2047      -42     
==========================================
- Hits         7255     7252       -3     
- Misses        265      268       +3     
  Partials        2        2
Impacted Files Coverage 螖
components/_util/wave.tsx 85.57% <0%> (-2.89%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 5e56dc5...8523470. Read the comment docs.

@ztplz
Copy link
Collaborator

left a comment

After I read the relevant information about website-accessibility-law, it should not be capitalized.
For example:
copy=> screen readers will read that as copy
COPY => screen readers will read that as C-O-P-Y
Copy => screen readers will read that as C-opy
@afc163 @zombieJ Any thought?
https://www.w3.org/WAI/WCAG21/Understanding/label-in-name.html
Sorry, correct my description, the capitalization will not affect the reader, but all caps will.

@hjiawei

This comment has been minimized.

Copy link
Contributor Author

commented Aug 26, 2019

Tasking the Typography as an example, the problem for me is that the tooltip isn't consistent (caps vs. no caps) with other tooltips in my UI. It would be better to have a way to override it by the user if we don't want to change the default. Also, "copy success" isn't really correct IMO.

@afc163 afc163 changed the title Capitalize Text and PageHeader default locale strings fix: Capitalize Text and PageHeader default locale strings Aug 27, 2019

@afc163 afc163 merged commit dba3ea8 into ant-design:master Aug 27, 2019

27 of 29 checks passed

Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 214 new files uploaded
Details
DEP All dependencies are resolved
LGTM analysis: JavaScript No new or fixed alerts
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No significant change
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 5e56dc5...8523470
Details
codecov/project 96.41% (-0.04%) compared to 5e56dc5
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Aug 27, 2019

@afc163 afc163 referenced this pull request Aug 27, 2019
5 of 14 tasks complete

@hjiawei hjiawei deleted the hjiawei:update-default-locale-str branch Aug 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.