Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Input.Password unmount crash #18475

Merged
merged 1 commit into from Aug 26, 2019
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Aug 26, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #18473

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Input.Password crash with Cannot read property 'input' of null when unmount.
🇨🇳 Chinese 修复 Input.Password unmount 时报错 Cannot read property 'input' of null。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@netlify
Copy link

netlify bot commented Aug 26, 2019

Deploy preview for ant-design ready!

Built with commit 304223a

https://deploy-preview-18475--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Aug 26, 2019

Codecov Report

Merging #18475 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18475      +/-   ##
==========================================
+ Coverage   96.41%   96.41%   +<.01%     
==========================================
  Files         280      280              
  Lines        7522     7523       +1     
  Branches     2047     2093      +46     
==========================================
+ Hits         7252     7253       +1     
  Misses        268      268              
  Partials        2        2
Impacted Files Coverage Δ
components/input/Password.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 493bd72...304223a. Read the comment docs.

@afc163 afc163 changed the title fix Input.Password unmount crash fix: Input.Password unmount crash Aug 26, 2019
@afc163 afc163 merged commit c9a703d into master Aug 26, 2019
24 checks passed
@afc163 afc163 deleted the fix-input-password-instance branch Aug 26, 2019
@afc163 afc163 mentioned this pull request Aug 27, 2019
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't read Input.Password property 'input' of null
1 participant