Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Mentions in Form has additional height #18478

Merged
merged 1 commit into from Aug 26, 2019

Conversation

@zombieJ
Copy link
Member

commented Aug 26, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #17347

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English 修复 Mentions 在 Form 中高度略高的问题。
🇨🇳 Chinese Fix Mentions has additional height in Form.

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/mentions/demo/form.md

@pr-triage pr-triage bot added the PR: unreviewed label Aug 26, 2019

@zombieJ zombieJ requested a review from afc163 Aug 26, 2019

@netlify

This comment has been minimized.

Copy link

commented Aug 26, 2019

Deploy preview for ant-design ready!

Built with commit 0c483e3

https://deploy-preview-18478--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Aug 26, 2019

Codecov Report

Merging #18478 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18478      +/-   ##
==========================================
- Coverage   96.41%   96.41%   -0.01%     
==========================================
  Files         280      280              
  Lines        7523     7522       -1     
  Branches     2048     2092      +44     
==========================================
- Hits         7253     7252       -1     
  Misses        268      268              
  Partials        2        2
Impacted Files Coverage Δ
components/input/Password.tsx 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9a703d...0c483e3. Read the comment docs.

@afc163 afc163 merged commit 7e9cc07 into master Aug 26, 2019

27 of 30 checks passed

Build
Details
Header rules - ant-design No header rules processed
Details
LGTM analysis: JavaScript No code changes detected
Details
Pages changed - ant-design 214 new files uploaded
Details
DEP All dependencies are resolved
License Compliance All checks passed.
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing c9a703d...0c483e3
Details
codecov/project 96.41% (-0.01%) compared to c9a703d
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details

@afc163 afc163 deleted the fix-mentions branch Aug 26, 2019

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Aug 26, 2019

@afc163 afc163 referenced this pull request Aug 27, 2019
5 of 14 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.