Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Input disabled should not be allowed to clear #18482

Merged
merged 1 commit into from Aug 26, 2019
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Aug 26, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #18481

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix disabled Input should not be allowed to clear.
🇨🇳 Chinese 修复失效 Input 依然支持 allowClear 的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@netlify
Copy link

netlify bot commented Aug 26, 2019

Deploy preview for ant-design ready!

Built with commit 02bad77

https://deploy-preview-18482--ant-design.netlify.com

@afc163 afc163 changed the title 🐛 Input disabled should not be allowed to clear fix: Input disabled should not be allowed to clear Aug 26, 2019
@codecov
Copy link

codecov bot commented Aug 26, 2019

Codecov Report

Merging #18482 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18482   +/-   ##
=======================================
  Coverage   96.41%   96.41%           
=======================================
  Files         280      280           
  Lines        7523     7523           
  Branches     2048     2079   +31     
=======================================
  Hits         7253     7253           
  Misses        268      268           
  Partials        2        2
Impacted Files Coverage Δ
components/input/Input.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e9cc07...02bad77. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant