Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: circle button is not circle #18516

Merged
merged 2 commits into from Aug 28, 2019

Conversation

@afc163
Copy link
Member

commented Aug 28, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #18509

💡 Background and solution

image

to

image

📝 Changelog

Language Changelog
🇺🇸 English Fix circle Button not circle in some situation.
🇨🇳 Chinese 修复圆形 Button 有时候不是圆形的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/button/demo/icon.md

@pr-triage pr-triage bot added the PR: unreviewed label Aug 28, 2019

@netlify

This comment has been minimized.

Copy link

commented Aug 28, 2019

Deploy preview for ant-design ready!

Built with commit 67cebf6

https://deploy-preview-18516--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Aug 28, 2019

Codecov Report

Merging #18516 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18516   +/-   ##
=======================================
  Coverage   96.73%   96.73%           
=======================================
  Files         280      280           
  Lines        7532     7532           
  Branches     2095     2095           
=======================================
  Hits         7286     7286           
  Misses        244      244           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be5760d...67cebf6. Read the comment docs.

@afc163 afc163 force-pushed the fix-circle-button branch from ca82372 to e770c13 Aug 28, 2019

@afc163 afc163 force-pushed the fix-circle-button branch from e770c13 to 67cebf6 Aug 28, 2019

@codecov

This comment has been minimized.

Copy link

commented Aug 28, 2019

Codecov Report

Merging #18516 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18516   +/-   ##
=======================================
  Coverage   96.73%   96.73%           
=======================================
  Files         280      280           
  Lines        7532     7532           
  Branches     2095     2095           
=======================================
  Hits         7286     7286           
  Misses        244      244           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be5760d...67cebf6. Read the comment docs.

@afc163 afc163 merged commit 5b5b828 into master Aug 28, 2019

28 of 30 checks passed

Build
Details
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 224 new files uploaded
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
License Compliance All checks passed.
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing be5760d...67cebf6
Details
codecov/project 96.73% remains the same compared to be5760d
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@afc163 afc163 deleted the fix-circle-button branch Aug 28, 2019

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Aug 28, 2019

@afc163 afc163 referenced this pull request Aug 29, 2019
4 of 14 tasks complete
@chenshuai2144 chenshuai2144 referenced this pull request Sep 2, 2019
5 of 14 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.