Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: circle button is not circle #18516

Merged
merged 2 commits into from Aug 28, 2019
Merged

fix: circle button is not circle #18516

merged 2 commits into from Aug 28, 2019

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Aug 28, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #18509

💡 Background and solution

image

to

image

📝 Changelog

Language Changelog
🇺🇸 English Fix circle Button not circle in some situation.
🇨🇳 Chinese 修复圆形 Button 有时候不是圆形的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/button/demo/icon.md

@netlify
Copy link

netlify bot commented Aug 28, 2019

Deploy preview for ant-design ready!

Built with commit 67cebf6

https://deploy-preview-18516--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Aug 28, 2019

Codecov Report

Merging #18516 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18516   +/-   ##
=======================================
  Coverage   96.73%   96.73%           
=======================================
  Files         280      280           
  Lines        7532     7532           
  Branches     2095     2095           
=======================================
  Hits         7286     7286           
  Misses        244      244           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be5760d...67cebf6. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 28, 2019

Codecov Report

Merging #18516 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18516   +/-   ##
=======================================
  Coverage   96.73%   96.73%           
=======================================
  Files         280      280           
  Lines        7532     7532           
  Branches     2095     2095           
=======================================
  Hits         7286     7286           
  Misses        244      244           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be5760d...67cebf6. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Circle button broken with new icon-only class
1 participant