Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change to arrow function #18541

Merged
merged 1 commit into from Aug 29, 2019

Conversation

@ZhengYuTay
Copy link
Contributor

commented Aug 29, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

  1. zeit/next.js/issues/8151

馃挕 Background and solution

  1. Stylechecker seems to be breaking serverless output with NextJS. Partial solution: Just a small refactor from function to arrow function.

馃摑 Changelog

  • Refactor hoisted function to variable arrow function
Language Changelog
馃嚭馃嚫 English Refactor hoisted function to variable arrow function
馃嚚馃嚦 Chinese

@pr-triage pr-triage bot added the PR: unreviewed label Aug 29, 2019

@netlify

This comment has been minimized.

Copy link

commented Aug 29, 2019

Deploy preview for ant-design ready!

Built with commit 25bbb17

https://deploy-preview-18541--ant-design.netlify.com

@afc163 afc163 changed the title Change to arrow function fix: Change to arrow function Aug 29, 2019

@afc163 afc163 merged commit 414de6b into ant-design:master Aug 29, 2019

25 of 27 checks passed

Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 214 new files uploaded
Details
DEP All dependencies are resolved
LGTM analysis: JavaScript No new or fixed alerts
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Aug 29, 2019

@afc163 afc163 referenced this pull request Sep 2, 2019
5 of 14 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.