Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(layoutSider): dimensionMap for max-width media query #18553

Merged
merged 1 commit into from Sep 3, 2019

Conversation

Nikitenkova
Copy link
Contributor

@Nikitenkova Nikitenkova commented Aug 29, 2019

According to visibility problem (on viewport breakpoints) with Sider menu in our App
And according to Bootstrap responsive breakpoints https://getbootstrap.com/docs/4.0/layout/overview/#responsive-breakpoints

We should use different values for min-width and max-width. For example, if we construct query with min-width: 768px then we MUST use max-width: 767.98px for proper breakpoint determination otherwise they conflict with each other when have similar values.

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

馃挕 Background and solution

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English Fix Layout.Sider boundary values for max-width
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

According to visibility problem (on viewport breakpoints) with Sider menu in our App
And according to Bootstrap responsive breakpoints https://getbootstrap.com/docs/4.0/layout/overview/#responsive-breakpoints

We should use different values for `min-width` and `max-width`. For example, if we construct query with `min-width: 768px` then we MUST use `max-width: 767.98px` for proper breakpoint determination otherwise they conflict with each other when have similar values.
@netlify
Copy link

netlify bot commented Aug 29, 2019

Deploy preview for ant-design ready!

Built with commit ff83e1a

https://deploy-preview-18553--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Aug 30, 2019

Codecov Report

Merging #18553 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18553   +/-   ##
=======================================
  Coverage   96.73%   96.73%           
=======================================
  Files         280      280           
  Lines        7532     7532           
  Branches     2053     2084   +31     
=======================================
  Hits         7286     7286           
  Misses        244      244           
  Partials        2        2
Impacted Files Coverage 螖
components/layout/Sider.tsx 95.6% <100%> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update c54bffb...ff83e1a. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Aug 30, 2019

Codecov Report

Merging #18553 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18553   +/-   ##
=======================================
  Coverage   96.73%   96.73%           
=======================================
  Files         280      280           
  Lines        7532     7532           
  Branches     2053     2084   +31     
=======================================
  Hits         7286     7286           
  Misses        244      244           
  Partials        2        2
Impacted Files Coverage 螖
components/layout/Sider.tsx 95.6% <100%> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update c54bffb...ff83e1a. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Aug 30, 2019

Could you fill the changelog part for information?

@afc163
Copy link
Member

afc163 commented Sep 3, 2019

@Nikitenkova

@Nikitenkova
Copy link
Contributor Author

Nikitenkova commented Sep 3, 2019

@afc163 done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants