Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adjust Descriptions column calcuation logic #18568

Merged
merged 2 commits into from Aug 30, 2019

Conversation

@zombieJ
Copy link
Member

commented Aug 30, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

fix #18527

📝 Changelog

Language Changelog
🇺🇸 English Fix Descriptions last Item has wrong calculated width issue.
🇨🇳 Chinese 修复 Descriptions Item 最后个宽度计算不正确的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/descriptions/demo/vertical.md

@pr-triage pr-triage bot added the PR: unreviewed label Aug 30, 2019

@tests-checker
Copy link

left a comment

Could you please add tests to make sure this change works as expected?

@netlify

This comment has been minimized.

Copy link

commented Aug 30, 2019

Deploy preview for ant-design ready!

Built with commit 6cdbded

https://deploy-preview-18568--ant-design.netlify.com

@afc163

This comment has been minimized.

Copy link
Member

commented Aug 30, 2019

写一下对现有规则有什么变化,对用户有什么影响?

@codecov

This comment has been minimized.

Copy link

commented Aug 30, 2019

Codecov Report

Merging #18568 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18568      +/-   ##
==========================================
- Coverage   96.73%   96.73%   -0.01%     
==========================================
  Files         280      280              
  Lines        7532     7531       -1     
  Branches     2053     2055       +2     
==========================================
- Hits         7286     7285       -1     
  Misses        244      244              
  Partials        2        2
Impacted Files Coverage Δ
components/descriptions/index.tsx 98.78% <100%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6091cf...6cdbded. Read the comment docs.

@zombieJ

This comment has been minimized.

Copy link
Member Author

commented Aug 30, 2019

这里就保守的修了最后一个 Item 的宽度计算逻辑,其他的没有改。

@zombieJ zombieJ merged commit 76fd806 into master Aug 30, 2019

30 of 32 checks passed

Build
Details
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 214 new files uploaded
Details
DEP All dependencies are resolved
LGTM analysis: JavaScript No new or fixed alerts
Details
License Compliance All checks passed.
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No prior size to compare - 848.09 KB
Details
bundlesize Total bundle size is 582.28KB/600KB (-null)
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 96.73%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +3.26% compared to e6091cf
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No new issues
Details

@zombieJ zombieJ deleted the descs branch Aug 30, 2019

@afc163

This comment has been minimized.

Copy link
Member

commented Aug 30, 2019

感觉好多现有 issue 都有关系:https://github.com/ant-design/ant-design/search?q=Descriptions&state=open&type=Issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.