Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Mentions should not collapse when prefix is empty #18576

Merged
merged 1 commit into from Aug 30, 2019
Merged

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Aug 30, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #18575

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Mentions popup position not correct when prefix is empty string.
🇨🇳 Chinese 修复 Mentions 的 prefix 为空字符串时,弹窗位置不正确的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Aug 30, 2019

Deploy preview for ant-design ready!

Built with commit 4bec232

https://deploy-preview-18576--ant-design.netlify.com

@zombieJ zombieJ requested a review from afc163 Aug 30, 2019
@codecov
Copy link

codecov bot commented Aug 30, 2019

Codecov Report

Merging #18576 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18576   +/-   ##
=======================================
  Coverage   96.73%   96.73%           
=======================================
  Files         280      280           
  Lines        7531     7531           
  Branches     2086     2055   -31     
=======================================
  Hits         7285     7285           
  Misses        244      244           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6995456...4bec232. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mentions 在 prefix ='' 中高度略高的问题
1 participant