Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Upload.Dragger should work with multiple is false #18580

Merged
merged 1 commit into from Aug 30, 2019
Merged

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Aug 30, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #17397

💡 Background and solution

📝 Changelog

Language Changelog
🇨🇳 Chinese 修复 Upload.Dragger 在 multiplefalse 时,仍然可以上传多份文件的问题。
🇺🇸 English Fix Upload.Dragger can upload multiple files when multiple is false.

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@netlify
Copy link

netlify bot commented Aug 30, 2019

Deploy preview for ant-design ready!

Built with commit 849de31

https://deploy-preview-18580--ant-design.netlify.com

@zombieJ zombieJ requested a review from afc163 Aug 30, 2019
@codecov
Copy link

codecov bot commented Aug 30, 2019

Codecov Report

Merging #18580 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18580      +/-   ##
==========================================
- Coverage   96.77%   96.73%   -0.04%     
==========================================
  Files         280      280              
  Lines        7534     7537       +3     
  Branches     2056     2102      +46     
==========================================
  Hits         7291     7291              
- Misses        241      244       +3     
  Partials        2        2
Impacted Files Coverage Δ
components/upload/Upload.tsx 95.55% <100%> (+0.1%) ⬆️
components/_util/wave.tsx 85.57% <0%> (-2.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dfed8d...849de31. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upload component allows multiple upload when multiple is set to false
2 participants