Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Upload.Dragger should work with multiple is false #18580

Merged
merged 1 commit into from Aug 30, 2019

Conversation

@zombieJ
Copy link
Member

commented Aug 30, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #17397

💡 Background and solution

📝 Changelog

Language Changelog
🇨🇳 Chinese 修复 Upload.Dragger 在 multiplefalse 时,仍然可以上传多份文件的问题。
🇺🇸 English Fix Upload.Dragger can upload multiple files when multiple is false.

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label Aug 30, 2019

@tests-checker
Copy link

left a comment

Could you please add tests to make sure this change works as expected?

@netlify

This comment has been minimized.

Copy link

commented Aug 30, 2019

Deploy preview for ant-design ready!

Built with commit 849de31

https://deploy-preview-18580--ant-design.netlify.com

@zombieJ zombieJ requested a review from afc163 Aug 30, 2019

@codecov

This comment has been minimized.

Copy link

commented Aug 30, 2019

Codecov Report

Merging #18580 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18580      +/-   ##
==========================================
- Coverage   96.77%   96.73%   -0.04%     
==========================================
  Files         280      280              
  Lines        7534     7537       +3     
  Branches     2056     2102      +46     
==========================================
  Hits         7291     7291              
- Misses        241      244       +3     
  Partials        2        2
Impacted Files Coverage Δ
components/upload/Upload.tsx 95.55% <100%> (+0.1%) ⬆️
components/_util/wave.tsx 85.57% <0%> (-2.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dfed8d...849de31. Read the comment docs.

@afc163 afc163 merged commit 06d7f0d into master Aug 30, 2019

28 of 32 checks passed

Build
Details
ant-design.ant-design in progress
Details
netlify/ant-design/deploy-preview Deploy preview processing.
Details
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 214 new files uploaded
Details
DEP All dependencies are resolved
LGTM analysis: JavaScript No new or fixed alerts
Details
License Compliance All checks passed.
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
buildsize No prior size to compare - 848.09 KB
Details
bundlesize Total bundle size is 582.45KB/600KB (-null)
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 96.77%)
Details
codecov/project Absolute coverage decreased by -0.03% but relative coverage increased by +3.22% compared to 4dfed8d
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@afc163 afc163 deleted the drapper-multiple branch Aug 30, 2019

@chenshuai2144 chenshuai2144 referenced this pull request Sep 2, 2019
5 of 14 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.