Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added locales for the Armenian language #18586

Merged
merged 4 commits into from Sep 2, 2019

Conversation

@ashmna
Copy link
Contributor

commented Aug 30, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (Internationalization)

🔗 Related issue link

Please add Armenian localization

💡 Background and solution

  1. There is no Armenian locale
  2. Just translate from en_US to Armenian (hy_AM)

📝 Changelog

Language Changelog
🇺🇸 English Added locales for the Armenian language
🇨🇳 Chinese 添加了亞美尼亞語的語言環境

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label Aug 30, 2019

@netlify

This comment has been minimized.

Copy link

commented Aug 30, 2019

Deploy preview for ant-design ready!

Built with commit 13bae84

https://deploy-preview-18586--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Aug 30, 2019

Codecov Report

Merging #18586 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18586      +/-   ##
==========================================
+ Coverage   96.73%   96.73%   +<.01%     
==========================================
  Files         280      281       +1     
  Lines        7537     7538       +1     
  Branches     2057     2088      +31     
==========================================
+ Hits         7291     7292       +1     
  Misses        244      244              
  Partials        2        2
Impacted Files Coverage Δ
components/locale/hy_AM.tsx 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06d7f0d...13bae84. Read the comment docs.

@afc163

This comment has been minimized.

Copy link
Member

commented Aug 31, 2019

Could u add test case like other locales and update documentation https://ant.design/docs/react/i18n ?

@ashmna

This comment has been minimized.

Copy link
Contributor Author

commented Sep 1, 2019

@afc163 Tanks you for the response
I have added the test case and the documentation as you mentioned,
Please review again

@afc163 afc163 changed the title Added locales for the Armenian language feat: Added locales for the Armenian language Sep 2, 2019

@afc163 afc163 changed the title feat: Added locales for the Armenian language feat: added locales for the Armenian language Sep 2, 2019

@afc163 afc163 merged commit 68a02a7 into ant-design:master Sep 2, 2019

27 of 29 checks passed

Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 216 new files uploaded
Details
DEP All dependencies are resolved
LGTM analysis: JavaScript No new or fixed alerts
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No significant change
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 96.73%)
Details
codecov/project 96.73% (+<.01%) compared to 06d7f0d
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Sep 2, 2019

@chenshuai2144 chenshuai2144 referenced this pull request Sep 2, 2019
5 of 14 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.