Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added locales for the Armenian language #18586

Merged
merged 4 commits into from Sep 2, 2019
Merged

feat: added locales for the Armenian language #18586

merged 4 commits into from Sep 2, 2019

Conversation

ashmna
Copy link
Contributor

@ashmna ashmna commented Aug 30, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (Internationalization)

馃敆 Related issue link

Please add Armenian localization

馃挕 Background and solution

  1. There is no Armenian locale
  2. Just translate from en_US to Armenian (hy_AM)

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English Added locales for the Armenian language
馃嚚馃嚦 Chinese 娣诲姞浜嗕簽缇庡凹浜炶獮鐨勮獮瑷鐠板

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Aug 30, 2019

Deploy preview for ant-design ready!

Built with commit 13bae84

https://deploy-preview-18586--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Aug 30, 2019

Codecov Report

Merging #18586 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18586      +/-   ##
==========================================
+ Coverage   96.73%   96.73%   +<.01%     
==========================================
  Files         280      281       +1     
  Lines        7537     7538       +1     
  Branches     2057     2088      +31     
==========================================
+ Hits         7291     7292       +1     
  Misses        244      244              
  Partials        2        2
Impacted Files Coverage 螖
components/locale/hy_AM.tsx 100% <100%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 06d7f0d...13bae84. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Aug 31, 2019

Could u add test case like other locales and update documentation https://ant.design/docs/react/i18n ?

@ashmna
Copy link
Contributor Author

ashmna commented Sep 1, 2019

@afc163 Tanks you for the response
I have added the test case and the documentation as you mentioned,
Please review again

@afc163 afc163 changed the title Added locales for the Armenian language feat: Added locales for the Armenian language Sep 2, 2019
@afc163 afc163 changed the title feat: Added locales for the Armenian language feat: added locales for the Armenian language Sep 2, 2019
@afc163 afc163 merged commit 68a02a7 into ant-design:master Sep 2, 2019
23 checks passed
@chenshuai2144 chenshuai2144 mentioned this pull request Sep 2, 2019
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants